r81080 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81079‎ | r81080 | r81081 >
Date:01:25, 27 January 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Improved the style of the survey dialog and cleaned some code that launches it.
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.css (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
@@ -45,7 +45,7 @@
4646 'modal': true,
4747 'title': mediaWiki.msg( 'articlefeedback-survey-title' ),
4848 'close': function() {
49 - $( this )
 49+ $(this)
5050 .dialog( 'option', 'height', 400 )
5151 .find( '.articleFeedback-success-msg, .articleFeedback-error-msg' )
5252 .remove()
@@ -55,10 +55,19 @@
5656 }
5757 } );
5858 $dialog.load(
59 - wgScript + '?title=Special:SimpleSurvey&survey=articlerating&raw=1',
 59+ mediaWiki.config.get( 'wgScript' ) +
 60+ '?title=Special:SimpleSurvey&survey=articlerating&raw=1',
6061 function() {
61 - //$( this ).find( 'form' ).bind( 'submit', $.ArticleAssessment.fn.submitFeedback );
62 - $( this ).removeClass( 'loading' );
 62+ $(this)
 63+ .append(
 64+ $( '<button></button>' )
 65+ .text( $(this).find( 'input[type=submit]' ).val() )
 66+ .button()
 67+ )
 68+ .find( 'input[type=submit]' )
 69+ .remove()
 70+ .end()
 71+ .removeClass( 'loading' );
6372 }
6473 );
6574 }
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.css
@@ -1,3 +1,7 @@
22 /*
33 * Styles for Article Feedback Extension
44 */
 5+#articleFeedback-dialog {
 6+ padding: 2em;
 7+ padding-top: 1em;
 8+}
\ No newline at end of file

Status & tagging log