r81070 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81069‎ | r81070 | r81071 >
Date:23:25, 26 January 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Fixed meter scale - now each segment is 21px.
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -164,7 +164,7 @@
165165 Math.round( ( average % 1 ) * 10 ) )
166166 .end()
167167 .find( '.articleFeedback-rating-meter div' )
168 - .css( 'width', Math.round( average * 20 ) + 'px' )
 168+ .css( 'width', Math.round( average * 21 ) + 'px' )
169169 .end()
170170 .find( '.articleFeedback-rating-count' )
171171 .text( mw.msg(
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css
@@ -174,6 +174,7 @@
175175 background-image: url(images/segment-empty.png);
176176 background-repeat: repeat-x;
177177 background-position: center left;
 178+ overflow: hidden;
178179 }
179180
180181 .articleFeedback-rating-meter div {

Status & tagging log