r81040 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81039‎ | r81040 | r81041 >
Date:17:48, 26 January 2011
Author:mah
Status:ok
Tags:
Comment:
* Whitespace fixups
* followup r66675 - Robla caught a problem with the parameter munging
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -168,7 +168,7 @@
169169 var $mFrom;
170170
171171 /**
172 - * Lazy-initialized variables, invalidated with clearInstanceCache
 172+ * Lazy-initialized variables, invalidated with clearInstanceCache
173173 */
174174 var $mNewtalk, $mDatePreference, $mBlockedby, $mHash, $mSkin, $mRights,
175175 $mBlockreason, $mBlock, $mEffectiveGroups, $mBlockedGlobally,
@@ -610,7 +610,7 @@
611611 */
612612 function getPasswordValidity( $password ) {
613613 global $wgMinimalPasswordLength, $wgContLang;
614 -
 614+
615615 static $blockedLogins = array(
616616 'Useruser' => 'Passpass', 'Useruser1' => 'Passpass1', # r75589
617617 'Apitestsysop' => 'testpass', 'Apitestuser' => 'testpass' # r75605
@@ -3830,7 +3830,7 @@
38313831 // Set newtalk with the right user ID
38323832 $this->setNewtalk( true );
38333833 wfRunHooks( 'AfterUserMessage',
3834 - array( $this, $article, $summary, $text, $signature, $summary, $editor ) );
 3834+ array( $this, $article, $subject, $text, $signature, $summary, $editor ) );
38353835 $dbw->commit();
38363836 } else {
38373837 // The article was concurrently created

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66675* Since it makes sense (to me :) to make the arguments for the two UserMessag...mah02:12, 20 May 2010

Status & tagging log