r81016 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81015‎ | r81016 | r81017 >
Date:08:57, 26 January 2011
Author:raymond
Status:ok
Tags:werdna 
Comment:
Sanitize the subject, otherweise HTML will be parsed, i.e. the <br> in http://translatewiki.net/w/i.php?title=Support&amp;offset=20110124124216#Add_%3Cbr%3E_in_pop-up_translation_panel_8106
Add space before the submit button
Modified paths:
  • /trunk/extensions/LiquidThreads/pages/NewUserMessagesView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/pages/NewUserMessagesView.php
@@ -38,7 +38,7 @@
3939 $t = Threads::withId( $ids[0] );
4040 if ( !$t )
4141 return; // empty or just bogus operand.
42 - $msg = wfMsgExt( 'lqt-marked-read', 'parseinline', array( $t->subject() ) );
 42+ $msg = wfMsgExt( 'lqt-marked-read', 'parseinline', LqtView::formatSubject( $t->subject() ) );
4343 } else {
4444 $count = count( $ids );
4545 $msg = wfMsgExt( 'lqt-count-marked-read', 'parseinline', array( $count ) );
@@ -49,7 +49,7 @@
5050 $html .= $msg;
5151 $html .= Html::hidden( 'lqt_method', 'mark_as_unread' );
5252 $html .= Html::hidden( 'lqt_operand', $operand );
53 - $html .= Xml::submitButton(
 53+ $html .= ' ' . Xml::submitButton(
5454 wfMsg( 'lqt-email-undo' ),
5555 array(
5656 'name' => 'lqt_read_button',

Status & tagging log