r81013 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81012‎ | r81013 | r81014 >
Date:04:24, 26 January 2011
Author:yaron
Status:deferred
Tags:
Comment:
Call to disable 'verifypeer' for Http::get() changed in MW 1.17
Modified paths:
  • /trunk/extensions/ExternalData/ED_Utils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ExternalData/ED_Utils.php
@@ -395,7 +395,9 @@
396396
397397 if ( !isset( $edgCacheTable ) || is_null( $edgCacheTable ) ) {
398398 if ( $edgAllowSSL ) {
399 - return Http::get( $url, 'default', array( CURLOPT_SSL_VERIFYPEER => false, 'followRedirects' => false ) );
 399+ // The hardcoded 'CURLOPT_SSL_VERIFYPEER' is
 400+ // needed for MW < 1.17
 401+ return Http::get( $url, 'default', array( CURLOPT_SSL_VERIFYPEER => false, 'sslVerifyCert' => false, 'followRedirects' => false ) );
400402 } else {
401403 return Http::get( $url );
402404 }

Status & tagging log