r80981 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80980‎ | r80981 | r80982 >
Date:19:53, 25 January 2011
Author:krinkle
Status:ok
Tags:
Comment:
Small fixes
* Missing space in SpecialPage.php
* Raising z-index of .suggestions (when used in a jQuery UI modal box the suggestion list appeared behind the modal instead of on top (ui modal has z-index: 1000; )
Modified paths:
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)
  • /trunk/phase3/resources/jquery/jquery.suggestions.css (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialPage.php
@@ -633,7 +633,7 @@
634634 $found = false;
635635 foreach ( $aliases as $n => $values ) {
636636 if ( strcasecmp( $name, $n ) === 0 ) {
637 - wfWarn( "Found alias defined for $n when searching for" .
 637+ wfWarn( "Found alias defined for $n when searching for " .
638638 "special page aliases for $name. Case mismatch?" );
639639 $name = $values[0];
640640 $found = true;
Index: trunk/phase3/resources/jquery/jquery.suggestions.css
@@ -7,7 +7,7 @@
88 left: 0px;
99 width: 0px;
1010 border: none;
11 - z-index: 99;
 11+ z-index: 1099;
1212 padding: 0;
1313 margin: -1px -1px 0 0;
1414 }

Status & tagging log