r80834 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80833‎ | r80834 | r80835 >
Date:20:27, 23 January 2011
Author:ialex
Status:ok
Tags:
Comment:
Assignment inside if clause is bad
Modified paths:
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialVersion.php
@@ -315,7 +315,8 @@
316316 $out .= '<tr><td colspan="4">' . $this->listToText( $tags ). "</td></tr>\n";
317317 }
318318
319 - if( count( $fhooks = $wgParser->getFunctionHooks() ) ) {
 319+ $fhooks = $wgParser->getFunctionHooks();
 320+ if( count( $fhooks ) ) {
320321 $out .= $this->openExtType( wfMsg( 'version-parser-function-hooks' ), 'parser-function-hooks' );
321322 $out .= '<tr><td colspan="4">' . $this->listToText( $fhooks ) . "</td></tr>\n";
322323 }

Status & tagging log