r80800 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80799‎ | r80800 | r80801 >
Date:09:46, 23 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Remove assignment in conditional

Fixup method parameter documentation
Modified paths:
  • /trunk/extensions/UploadWizard/UploadWizardTutorial.php (modified) (history)
  • /trunk/extensions/WikiEditor/WikiEditor.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/WikiEditor.hooks.php
@@ -208,8 +208,8 @@
209209 *
210210 * Adds WikiEditor-releated items to the preferences
211211 *
212 - * @param $out User current user
213 - * @param $skin array list of default user preference controls
 212+ * @param $user User current user
 213+ * @param $defaultPreferences array list of default user preference controls
214214 */
215215 public static function getPreferences( $user, &$defaultPreferences ) {
216216 global $wgWikiEditorFeatures;
Index: trunk/extensions/UploadWizard/UploadWizardTutorial.php
@@ -60,7 +60,8 @@
6161 // put it into a div of appropriate dimensions.
6262
6363 // n.b. File::transform() returns false if failed, MediaTransformOutput otherwise
64 - if ( $thumbnailImage = $tutorialFile->transform( array( 'width' => self::WIDTH_PX ) ) ) {
 64+ $thumbnailImage = $tutorialFile->transform( array( 'width' => self::WIDTH_PX ) );
 65+ if ( $thumbnailImage ) {
6566 $tutorialHtml = self::getImageHtml( $thumbnailImage );
6667 } else {
6768 $error = 'cannot-transform';

Status & tagging log