r80713 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r80712‎ \| r80713 \| r80714 >
Date:	22:05, 21 January 2011
Author:	reedy
Status:	ok (Comments)
Tags:
Comment:	Add missing $wgExtensionCredits
Modified paths:	/trunk/extensions/Aggregator/Aggregator.php (modified) (history) /trunk/extensions/Citation/Citation.php (modified) (history) /trunk/extensions/CodeBrowse/CodeBrowse.php (modified) (history) /trunk/extensions/FileSearch/FileSearch.php (modified) (history) /trunk/extensions/FootNote/Footnote.php (modified) (history) /trunk/extensions/FormPreloadPostCache/FormPreloadPostCache.php (modified) (history) /trunk/extensions/JIRA/JIRA.php (modified) (history) /trunk/extensions/ListChangedArticles/ListChangedArticles.php (modified) (history) /trunk/extensions/MWBlocker/MWBlockerHook.php (modified) (history) /trunk/extensions/MogileClient/SpecialUploadMogile.php (modified) (history) /trunk/extensions/Multilang/Multilang.php (modified) (history) /trunk/extensions/Preview/Preview.php (modified) (history) /trunk/extensions/PrivateNamespaces/PrivateNamespaces.php (modified) (history) /trunk/extensions/RSSNews/RSSNews.php (modified) (history) /trunk/extensions/SisterSites/SisterSites.php (modified) (history) /trunk/extensions/StaticWiki/StaticWiki.php (modified) (history) /trunk/extensions/TrustedMath/TrustedMath.php (modified) (history) /trunk/extensions/WiktionaryInflection/WiktionaryInflection.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SisterSites/SisterSites.php
—	—	@@ -12,6 +12,13 @@
13	13	* - lots of things ;)
14	14	*/
15	15
	16	+$wgExtensionCredits['other'][] = array(
	17	+ 'path' => __FILE__,
	18	+ 'name' => 'SisterSites',
	19	+ 'author' => '',
	20	+ 'url' => 'http://www.mediawiki.org/wiki/Extension:SisterSites',
	21	+);
	22	+
16	23	// This should be in a footer. meh
17	24	$wgHooks['BeforePageDisplay'][] = 'wfSisterDisplay';
18	25
Index: trunk/extensions/WiktionaryInflection/WiktionaryInflection.php
—	—	@@ -1,4 +1,12 @@
2	2	<?php
	3	+
	4	+$wgExtensionCredits['parserhooks'][] = array(
	5	+ 'path' => __FILE__,
	6	+ 'name' => 'WitionaryInflection',
	7	+ 'url' => 'http://www.mediawiki.org/wiki/Extension:WitionaryInflection',
	8	+ 'author' => '',
	9	+);
	10	+
3	11	$wgExtensionFunctions[] = "wfInflectionExtension";
4	12
5	13	function wfInflectionExtension() {
Index: trunk/extensions/FootNote/Footnote.php
—	—	@@ -34,6 +34,12 @@
35	35	die();
36	36	}
37	37
	38	+$wgExtensionCredits['parserhook'][] = array(
	39	+ 'path' => __FILE__,
	40	+ 'name' => 'Footnote',
	41	+ 'author' => '',
	42	+ 'url' => 'http://www.mediawiki.org/wiki/Extension:Footnote',
	43	+);
38	44
39	45	$wgExtensionFunctions[] = "wfFootnote";
40	46
Index: trunk/extensions/StaticWiki/StaticWiki.php
—	—	@@ -16,6 +16,13 @@
17	17
18	18	if (!defined('MEDIAWIKI')) die();
19	19
	20	+$wgExtensionCredits['other'][] = array(
	21	+ 'path' => __FILE__,
	22	+ 'name' => 'StaticWiki',
	23	+ 'author' => '',
	24	+ 'url' => 'http://www.mediawiki.org/wiki/Extension:StaticWiki',
	25	+);
	26	+
20	27	$wgHooks['AlternateEdit'][] = 'wfStaticEditHook' ;
21	28
22	29	function wfStaticWikiGetRevisionText ( $url_title , $revision ) {
Index: trunk/extensions/ListChangedArticles/ListChangedArticles.php
—	—	@@ -6,6 +6,13 @@
7	7	exit(1);
8	8	}
9	9
	10	+$wgExtensionCredits['specialpage '][] = array(
	11	+ 'path' => __FILE__,
	12	+ 'name' => 'ListChangedArticles',
	13	+ 'author' => '',
	14	+ 'url' => 'http://www.mediawiki.org/wiki/Extension:ListChangedArticles',
	15	+);
	16	+
10	17	$dir = dirname(__FILE__) . '/';
11	18	$wgAutoloadClasses['ListChangedArticles'] = $dir . 'ListChangedArticles_body.php';
12	19	$wgSpecialPages['ListChangedArticles'] = 'ListChangedArticles';
Index: trunk/extensions/MogileClient/SpecialUploadMogile.php
—	—	@@ -9,6 +9,13 @@
10	10	*/
11	11	require_once( 'MogileFS.php' );
12	12
	13	+$wgExtensionCredits['specialpage'][] = array(
	14	+ 'path' => __FILE__,
	15	+ 'name' => 'MogileClient',
	16	+ 'author' => '',
	17	+ 'url' => 'http://www.mediawiki.org/wiki/Extension:MogileClient',
	18	+);
	19	+
13	20	/**
14	21	* Entry point
15	22	*/
Index: trunk/extensions/RSSNews/RSSNews.php
—	—	@@ -3,6 +3,13 @@
4	4	# Adds news from an RSS feed to your wiki
5	5	# To use, include this file from your LocalSettings.php
6	6
	7	+$wgExtensionCredits['parserhook'][] = array(
	8	+ 'path' => __FILE__,
	9	+ 'name' => 'RSSNews',
	10	+ 'author' => '',
	11	+ 'url' => 'http://www.mediawiki.org/wiki/Extension:RSSNews',
	12	+);
	13	+
7	14	$wgExtensionFunctions[] = "wfRSSFeedExtension";
8	15
9	16	function wfRSSFeedExtension() {
Index: trunk/extensions/PrivateNamespaces/PrivateNamespaces.php
—	—	@@ -48,6 +48,13 @@
49	49	*
50	50	*/
51	51
	52	+$wgExtensionCredits['other'][] = array(
	53	+ 'path' => __FILE__,
	54	+ 'name' => 'PrivateNamespaces',
	55	+ 'author' => '',
	56	+ 'url' => 'http://www.mediawiki.org/wiki/Extension:PrivateNamespaces',
	57	+);
	58	+
52	59	/**
53	60	* An array mapping namespace ids to the right needed to view or edit
54	61	* pages in the namespace.
Index: trunk/extensions/TrustedMath/TrustedMath.php
—	—	@@ -27,6 +27,12 @@
28	28
29	29	*/
30	30
	31	+$wgExtensionCredits['parserhooks'][] = array(
	32	+ 'path' => __FILE__,
	33	+ 'name' => 'TrustedMath',
	34	+ 'url' => 'http://www.mediawiki.org/wiki/Extension:TrustedMath',
	35	+ 'author' => 'Bryan Tong Minh',
	36	+);
31	37
32	38	$dir = dirname( __FILE__ );
33	39	$wgAutoloadClasses['TrustedMath'] = "$dir/TrustedMath_body.php";
Index: trunk/extensions/Citation/Citation.php
—	—	@@ -3,6 +3,12 @@
4	4	#
5	5	# There is a <citation>author=Manske M \|\|title="The best paper ever" \|\|journal=''Biochemistry'' \|\|volume='''5''', 11</citation> citation here!
6	6
	7	+$wgExtensionCredits['parserhooks'][] = array(
	8	+ 'path' => __FILE__,
	9	+ 'name' => 'Citation',
	10	+ 'url' => 'http://www.mediawiki.org/wiki/Extension:Citation',
	11	+ 'author' => 'Magnus Manske',
	12	+);
7	13
8	14	$wgHooks['ParserBeforeTidy'][] = 'citation_hooker';
9	15	$wgHooks['ParserClearState'][] = 'citation_clear_state';
Index: trunk/extensions/JIRA/JIRA.php
—	—	@@ -43,6 +43,13 @@
44	44	# is a quick search string, as describe at
45	45	# http://www.atlassian.com/software/jira/docs/v3.11/quicksearch.html
46	46
	47	+$wgExtensionCredits['parserhook'][] = array(
	48	+ 'path' => __FILE__,
	49	+ 'name' => 'JIRA',
	50	+ 'author' => 'River Tarnell',
	51	+ 'url' => 'http://www.mediawiki.org/wiki/Extension:JIRA',
	52	+);
	53	+
47	54	$wgExtensionFunctions[] = 'efJIRASetup';
48	55
49	56	function efJIRASetup() {
Index: trunk/extensions/FileSearch/FileSearch.php
—	—	@@ -14,6 +14,13 @@
15	15	exit( 1 );
16	16	}
17	17
	18	+$wgExtensionCredits['other'][] = array(
	19	+ 'path' => __FILE__,
	20	+ 'name' => 'FileSearch',
	21	+ 'author' => '',
	22	+ 'url' => 'http://www.mediawiki.org/wiki/Extension:FileSearch',
	23	+);
	24	+
18	25	$wgExtensionFunctions[] = 'efFileSearchSetup';
19	26	$wgAutoloadClasses['FileSearchIndexer'] = dirname( __FILE__ ) . '/FileSearchIndexer.php';
20	27	$wgAutoloadClasses['Extractor'] = dirname( __FILE__ ) . '/extract/Extractor.php';
Index: trunk/extensions/MWBlocker/MWBlockerHook.php
—	—	@@ -2,6 +2,13 @@
3	3
4	4	require_once( 'MWBlocker.php' );
5	5
	6	+$wgExtensionCredits['other'][] = array(
	7	+ 'path' => __FILE__,
	8	+ 'name' => 'BlockerHook',
	9	+ 'author' => '',
	10	+ 'url' => 'http://www.mediawiki.org/wiki/Extension:BlockerHook',
	11	+);
	12	+
6	13	$wgExtensionFunctions[] = 'mwBlockerHookSetup';
7	14
8	15	function mwBlockerHookSetup() {
Index: trunk/extensions/Multilang/Multilang.php
—	—	@@ -10,6 +10,13 @@
11	11
12	12	if( defined( 'MEDIAWIKI' ) ) {
13	13
	14	+ $wgExtensionCredits['parserhook'][] = array(
	15	+ 'path' => __FILE__,
	16	+ 'name' => 'Multilang',
	17	+ 'author' => '',
	18	+ 'url' => 'http://www.mediawiki.org/wiki/Extension:Multilang',
	19	+ );
	20	+
14	21	$wgAutoloadClasses['Multilang'] = dirname( __FILE__ ) . '/Multilang.class.php';
15	22	$wgExtensionFunctions[] = 'efMultilang';
16	23
Index: trunk/extensions/CodeBrowse/CodeBrowse.php
—	—	@@ -7,6 +7,13 @@
8	8	* Author: Bryan Tong Minh
9	9	*/
10	10
	11	+$wgExtensionCredits['specialpage'][] = array(
	12	+ 'path' => __FILE__,
	13	+ 'name' => 'CodeBrowse',
	14	+ 'url' => 'http://www.mediawiki.org/wiki/Extension:CodeBrowse',
	15	+ 'author' => 'Bryan Tong Minh',
	16	+);
	17	+
11	18	$dir = dirname( __FILE__ );
12	19	$wgAutoloadClasses['CodeBrowseView'] = $dir . '/CodeBrowseView.php';
13	20	$wgAutoloadClasses['CodeBrowseItemView'] = $dir . '/CodeBrowseItemView.php';
Index: trunk/extensions/FormPreloadPostCache/FormPreloadPostCache.php
—	—	@@ -13,6 +13,13 @@
14	14	exit( 1 );
15	15	}
16	16
	17	+$wgExtensionCredits['other'][] = array(
	18	+ 'path' => __FILE__,
	19	+ 'name' => 'FormPreloadPostCache',
	20	+ 'author' => '',
	21	+ 'url' => 'http://www.mediawiki.org/wiki/Extension:FormPreloadPostCache',
	22	+);
	23	+
17	24	$wgHooks['OutputPageBeforeHTML'][] = 'FormPreloadPostCache::htmlHook';
18	25
19	26	class FormPreloadPostCache {
Index: trunk/extensions/Aggregator/Aggregator.php
—	—	@@ -6,6 +6,12 @@
7	7	global $wgAggregatorExpiry;
8	8	global $wgExtensionFunctions;
9	9
	10	+$wgExtensionCredits['parserhooks'][] = array(
	11	+ 'path' => __FILE__,
	12	+ 'name' => 'Aggregator',
	13	+ 'url' => 'http://www.mediawiki.org/wiki/Extension:Aggregator',
	14	+ 'author' => 'Brion Vibber',
	15	+);
10	16
11	17	// Do not poll remote feeds more often than every 30 minutes
12	18	$wgAggregatorExpiry = 1800;
Index: trunk/extensions/Preview/Preview.php
—	—	@@ -3,6 +3,13 @@
4	4	if (!defined('MEDIAWIKI'))
5	5	die;
6	6
	7	+$wgExtensionCredits['specialpage'][] = array(
	8	+ 'path' => __FILE__,
	9	+ 'name' => 'Preview',
	10	+ 'author' => '',
	11	+ 'url' => 'http://www.mediawiki.org/wiki/Extension:Preview',
	12	+);
	13	+
7	14	$wgSpecialPages['Preview'] = 'SpecialPreview';
8	15
9	16	class SpecialPreview extends SpecialPage {

Comments

#Comment by Siebrand (talk | contribs) 23:03, 21 January 2011

Some sloppyness in here. Empty author strings should probably be avoided and commented out.

Status & tagging log

22:10, 30 January 2011 MarkAHershberger (talk | contribs) changed the tags for r80713 [removed: trevor]
22:10, 30 January 2011 MarkAHershberger (talk | contribs) changed the status of r80713 [removed: new added: ok]
03:57, 26 January 2011 MarkAHershberger (talk | contribs) changed the tags for r80713 [added: trevor]