r80660 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80659‎ | r80660 | r80661 >
Date:22:37, 20 January 2011
Author:reedy
Status:deferred
Tags:
Comment:
Missing ; in JS in extensions we care about
Modified paths:
  • /trunk/extensions/AjaxQueryPages/AjaxQueryPages.js (modified) (history)
  • /trunk/extensions/CategoryTree/CategoryTree.js (modified) (history)
  • /trunk/extensions/Collection/js/bookcreator.js (modified) (history)
  • /trunk/extensions/Collection/js/jstorage.js (modified) (history)
  • /trunk/extensions/CommunityVoice/Resources/CommunityVoice.js (modified) (history)
  • /trunk/extensions/OggHandler/OggPlayer.js (modified) (history)
  • /trunk/extensions/ProofreadPage/proofread.js (modified) (history)
  • /trunk/extensions/Translate/utils/JsSelectToInput.js (modified) (history)
  • /trunk/extensions/wikihiero/index.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/js/bookcreator.js
@@ -72,7 +72,7 @@
7373 function createDiv() {
7474 addremove_link = $('<a href="javascript:void(0)" />');
7575 popup_div = $('<div id="collectionpopup" />');
76 - popup_div.append(addremove_link)
 76+ popup_div.append(addremove_link);
7777 $('body').append(popup_div);
7878 popup_div.hide();
7979 }
Index: trunk/extensions/Collection/js/jstorage.js
@@ -137,7 +137,7 @@
138138 // If userData is used as the storage engine, additional
139139 if(this._storage_elm){
140140 try{
141 - this._storage_elm.setAttribute("jStorage",this._storage_service.jStorage)
 141+ this._storage_elm.setAttribute("jStorage",this._storage_service.jStorage);
142142 this._storage_elm.save("jStorage");
143143 }catch(E){/* probably cache is full, nothing is saved this way*/}
144144 }
@@ -206,7 +206,7 @@
207207 this._save();
208208 return true;
209209 }
210 - }
 210+ };
211211 // load saved data from browser
212212 $.jStorage._init();
213213 })(typeof jQuery != "undefined" && jQuery || $);
\ No newline at end of file
Index: trunk/extensions/OggHandler/OggPlayer.js
@@ -720,7 +720,7 @@
721721 if ( !xiphQtVersion || xiphQtVersion == '0.0' ) {
722722 var div = document.createElement( 'div' );
723723 div.className = 'ogg-player-options';
724 - div.style.cssText = 'width:' + ( params.width - 10 ) + 'px;'
 724+ div.style.cssText = 'width:' + ( params.width - 10 ) + 'px;';
725725 div.innerHTML = this_.getMsg( 'ogg-no-xiphqt' );
726726 var optionsDiv = document.getElementById( params.id + '_options_box' );
727727 if ( optionsDiv ) {
Index: trunk/extensions/CommunityVoice/Resources/CommunityVoice.js
@@ -26,7 +26,7 @@
2727 return true;
2828 }
2929 return false;
30 - }
 30+ };
3131 /**
3232 * Removes an object form pool
3333 * @param id ID number of object to remove
@@ -39,7 +39,7 @@
4040 return true;
4141 }
4242 return false;
43 - }
 43+ };
4444 /**
4545 * Gets an object from pool
4646 * @param id ID number of object to get
@@ -80,7 +80,7 @@
8181
8282 this.getId = function() {
8383 return id;
84 - }
 84+ };
8585
8686 this.rate = function(
8787 newRating
@@ -112,7 +112,7 @@
113113 );
114114 // Restores current request type
115115 sajax_request_type = oldRequestType;
116 - }
 116+ };
117117
118118 this.respond = function(
119119 request
@@ -149,21 +149,21 @@
150150 }
151151 // Updates UI
152152 self.update();
153 - }
 153+ };
154154
155155 this.lock = function() {
156156 locked = true;
157157 for ( star in stars ) {
158158 stars[star].style.cursor = 'default';
159159 }
160 - }
 160+ };
161161
162162 this.unlock = function() {
163163 locked = false;
164164 for ( star in stars ) {
165165 stars[star].style.cursor = 'pointer';
166166 }
167 - }
 167+ };
168168
169169 this.update = function(
170170 hoveredStar
@@ -191,7 +191,7 @@
192192 labels.stats.className = 'stats';
193193 labels.status.innerHTML = messages.status[status];
194194 labels.status.className = status;
195 - }
 195+ };
196196
197197 // Loops 5 times (once per star)
198198 for ( var i = 0; i < 5; i++ ) {
Index: trunk/extensions/ProofreadPage/proofread.js
@@ -579,7 +579,7 @@
580580 );
581581 }
582582 }
583 -}
 583+};
584584
585585 function pr_zoom_wheel( evt ) {
586586 evt = evt ? evt : window.event ? window.event : null;
@@ -936,7 +936,7 @@
937937 }
938938 form.elements['wpSummary'].value = '/* ' + text + ' */ ';
939939 form.elements['wpProofreader'].value = self.proofreadpage_username;
940 -}
 940+};
941941
942942 function pr_add_quality_buttons() {
943943 var ig = document.getElementById( 'wpWatchthis' );
Index: trunk/extensions/wikihiero/index.php
@@ -127,13 +127,13 @@
128128
129129 function LangLink(l)
130130 {
131 - document.wh_form.lang.value = l
132 - document.wh_form.submit()
 131+ document.wh_form.lang.value = l;
 132+ document.wh_form.submit();
133133 }
134134
135135 function DisableScale(l)
136136 {
137 - document.wh_form.scale.disabled = l
 137+ document.wh_form.scale.disabled = l;
138138 }
139139
140140 </SCRIPT>
Index: trunk/extensions/CategoryTree/CategoryTree.js
@@ -32,7 +32,7 @@
3333 div.style.display= 'block';
3434 lnk.innerHTML= categoryTreeCollapseBulletMsg;
3535 lnk.title= categoryTreeCollapseMsg;
36 - lnk.onclick= function() { categoryTreeCollapseNode(cat, options, lnk) }
 36+ lnk.onclick= function() { categoryTreeCollapseNode(cat, options, lnk) };
3737
3838 if (!lnk.className.match(/(^| )CategoryTreeLoaded($| )/)) {
3939 categoryTreeLoadNode(cat, options, lnk, div);
@@ -53,7 +53,7 @@
5454 lnk.className= 'CategoryTreeLoaded';
5555 lnk.innerHTML= categoryTreeCollapseBulletMsg;
5656 lnk.title= categoryTreeCollapseMsg;
57 - lnk.onclick= function() { categoryTreeCollapseNode(cat, options, lnk) }
 57+ lnk.onclick= function() { categoryTreeCollapseNode(cat, options, lnk) };
5858
5959 categoryTreeLoadChildren(cat, options, div)
6060 }
@@ -116,7 +116,7 @@
117117 retryLink.innerHTML = categoryTreeRetryMsg;
118118 retryLink.onclick = function() {
119119 categoryTreeLoadChildren(cat, options, div, enc);
120 - }
 120+ };
121121 div.appendChild(retryLink);
122122 return;
123123 }
Index: trunk/extensions/Translate/utils/JsSelectToInput.js
@@ -1,9 +1,9 @@
22 function appendFromSelect(selectid,targetid) {
33 var select = document.getElementById(selectid);
44 var target = document.getElementById(targetid);
5 - if(!target || !select) return
 5+ if(!target || !select) return;
66 var atxt = select.options[select.selectedIndex].value;
7 - if(!atxt) return
 7+ if(!atxt) return;
88 /* Ugly hack */
99 target.value = target.value.replace(/default/, '' );
1010 if(target.value.replace(/[\s\t\n]/ig,'') != '') atxt = ', ' + atxt;
Index: trunk/extensions/AjaxQueryPages/AjaxQueryPages.js
@@ -4,7 +4,7 @@
55
66 wgAjaxQueryPages.onLoad = function() {
77 wgAjaxQueryPages.replacelinks( document );
8 -}
 8+};
99
1010 wgAjaxQueryPages.replacelinks = function( target ) {
1111 var elsPrev = getElementsByClassName(target, "a", "mw-prevlink");

Status & tagging log