r80620 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80619‎ | r80620 | r80621 >
Date:09:37, 20 January 2011
Author:tstarling
Status:ok
Tags:
Comment:
Revert r75769, r80475: mistaken attempt to fix bug 25725 by deleting random newlines from the output of a different diff engine.
Modified paths:
  • /trunk/phase3/HISTORY (modified) (history)
  • /trunk/phase3/includes/diff/WikiDiff.php (modified) (history)

Diff [purge]

Index: trunk/phase3/HISTORY
@@ -406,7 +406,6 @@
407407 * (bug 25642) A exception is now thrown instead of a fatal error when using
408408 $wgSMTP without PEAR mail package
409409 * (bug 19633) When possible, Upscale small SVGs when creating thumbnails.
410 -* (bug 25725) Unwanted linebreaks in diffs.
411410 * (bug 11013) Database driver detection needs rewriting for robustness
412411 * (bug 13409) Installer prompts could use clarification--now has help boxes
413412 * (bug 16902) Installer spews warnings when exec() and dl() are not available
Index: trunk/phase3/includes/diff/WikiDiff.php
@@ -1045,7 +1045,7 @@
10461046
10471047 function getLines() {
10481048 $this->_flushLine( '~done' );
1049 - return str_replace( '\n', '', $this->_lines );
 1049+ return $this->_lines;
10501050 }
10511051 }
10521052

Follow-up revisions

RevisionCommit summaryAuthorDate
r80621Fix for bug 25725: don't insert any whitespace inside the divs, so that "whit...tstarling09:53, 20 January 2011
r806771.17: MFT r80109, r80113, r80223, r80475, r80554, r80575, r80620, r80621, r80...catrope03:12, 21 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75769Avoid unnecessary linebreaks in difflines. Fixes bug 25725hartman00:14, 1 November 2010
r80475Use str_replace instead of preg_replace. Follow up of r75769hartman23:16, 17 January 2011

Status & tagging log