r80584 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80583‎ | r80584 | r80585 >
Date:19:36, 19 January 2011
Author:kaldari
Status:ok
Tags:
Comment:
dont want to use HTTP-only for these cookies
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialHideBanners.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialHideBanners.php
@@ -27,7 +27,7 @@
2828 }
2929
3030 function setHideCookie() {
31 - global $wgNoticeCookieDomain, $wgCookieSecure, $wgCookieHttpOnly;
 31+ global $wgNoticeCookieDomain, $wgCookieSecure;
3232 $exp = time() + 86400 * 14; // Cookie expires after 2 weeks
3333 if ( is_callable( 'CentralAuthUser', 'getCookieDomain' ) ) {
3434 $cookieDomain = CentralAuthUser::getCookieDomain();
@@ -35,6 +35,6 @@
3636 $cookieDomain = $wgNoticeCookieDomain;
3737 }
3838 // Hide banners for this domain
39 - setcookie( 'hidesnmessage', '1', $exp, '/', $cookieDomain, $wgCookieSecure, $wgCookieHttpOnly );
 39+ setcookie( 'hidesnmessage', '1', $exp, '/', $cookieDomain, $wgCookieSecure );
4040 }
4141 }

Status & tagging log