r80551 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r80550‎ \| r80551 \| r80552 >
Date:	02:37, 19 January 2011
Author:	kaldari
Status:	deferred
Tags:
Comment:	fixing placeholder problem for people named First Last
Modified paths:	/trunk/extensions/DonationInterface/payflowpro_gateway/forms/Form.php (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/OneStepTwoColumn.php (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter7.php (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumn.php (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter3.php (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnPremiumUS.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter7.php
—	—	@@ -17,8 +17,8 @@
18	18	global $wgOut;
19	19	// form placeholder values
20	20	$other = wfMsg( 'payflowpro_gateway-other' );
21		~~- $first = wfMsg( 'payflowpro_gateway-first' );~~
22		~~- $last = wfMsg( 'payflowpro_gateway-last' );~~
	21	+ $first = wfMsg( 'payflowpro_gateway-donor-fname' );
	22	+ $last = wfMsg( 'payflowpro_gateway-donor-lname' );
23	23	$street = wfMsg( 'payflowpro_gateway-donor-street' );
24	24	$city = wfMsg( 'payflowpro_gateway-donor-city' );
25	25	$zip = wfMsg( 'payflowpro_gateway-zip-code' );
—	—	@@ -294,8 +294,8 @@
295	295	$form .= '</tr>';
296	296	$form .= '<tr>';
297	297	$form .= '<td class="label">' . Xml::label( wfMsg( 'payflowpro_gateway-name-on-card' ), 'fname' ) . '</td>';
298		- $form .= '<td>' . Xml::input( 'fname', '30', $this->form_data['fname'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-first' ).'\' )', 'maxlength' => '25', 'class' => 'required', 'id' => 'fname' ) ) .
299		- Xml::input( 'lname', '30', $this->form_data['lname'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-last' ).'\' )', 'maxlength' => '25', 'id' => 'lname' ) ) . '</td>';
	298	+ $form .= '<td>' . Xml::input( 'fname', '30', $this->form_data['fname'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-donor-fname' ).'\' )', 'maxlength' => '25', 'class' => 'required', 'id' => 'fname' ) ) .
	299	+ Xml::input( 'lname', '30', $this->form_data['lname'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-donor-lname' ).'\' )', 'maxlength' => '25', 'id' => 'lname' ) ) . '</td>';
300	300	$form .= "</tr>";
301	301
302	302	// street
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/Form.php
—	—	@@ -549,8 +549,8 @@
550	550	$form .= '</tr>';
551	551	$form .= '<tr>';
552	552	$form .= '<td class="label">' . Xml::label( wfMsg( 'payflowpro_gateway-donor-name' ), 'fname' ) . '</td>';
553		- $form .= '<td>' . Xml::input( 'fname', '30', $this->form_data['fname'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-first' ).'\' )', 'maxlength' => '25', 'class' => 'required', 'id' => 'fname' ) ) .
554		- Xml::input( 'lname', '30', $this->form_data['lname'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-last' ).'\' )', 'maxlength' => '25', 'id' => 'lname' ) ) . '</td>';
	553	+ $form .= '<td>' . Xml::input( 'fname', '30', $this->form_data['fname'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-donor-fname' ).'\' )', 'maxlength' => '25', 'class' => 'required', 'id' => 'fname' ) ) .
	554	+ Xml::input( 'lname', '30', $this->form_data['lname'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-donor-lname' ).'\' )', 'maxlength' => '25', 'id' => 'lname' ) ) . '</td>';
555	555	$form .= "</tr>";
556	556	return $form;
557	557	}
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumn.php
—	—	@@ -16,8 +16,8 @@
17	17	public function loadPlaceholders() {
18	18	global $wgOut;
19	19	// form placeholder values
20		~~- $first = wfMsg( 'payflowpro_gateway-first' );~~
21		~~- $last = wfMsg( 'payflowpro_gateway-last' );~~
	20	+ $first = wfMsg( 'payflowpro_gateway-donor-fname' );
	21	+ $last = wfMsg( 'payflowpro_gateway-donor-lname' );
22	22	$js = <<<EOT
23	23	<script type="text/javascript">
24	24	function loadPlaceholders() {
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter3.php
—	—	@@ -15,8 +15,8 @@
16	16	public function loadPlaceholders() {
17	17	global $wgOut;
18	18	// form placeholder values
19		~~- $first = wfMsg( 'payflowpro_gateway-first' );~~
20		~~- $last = wfMsg( 'payflowpro_gateway-last' );~~
	19	+ $first = wfMsg( 'payflowpro_gateway-donor-fname' );
	20	+ $last = wfMsg( 'payflowpro_gateway-donor-lname' );
21	21	$street = wfMsg( 'payflowpro_gateway-donor-street' );
22	22	$city = wfMsg( 'payflowpro_gateway-donor-city' );
23	23	$zip = wfMsg( 'payflowpro_gateway-zip-code' );
—	—	@@ -274,8 +274,8 @@
275	275	$form .= '</tr>';
276	276	$form .= '<tr>';
277	277	$form .= '<td class="label">' . Xml::label( wfMsg( 'payflowpro_gateway-name-on-card' ), 'fname' ) . '</td>';
278		- $form .= '<td>' . Xml::input( 'fname', '30', $this->form_data['fname'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-first' ).'\' )', 'maxlength' => '25', 'class' => 'required', 'id' => 'fname' ) ) .
279		- Xml::input( 'lname', '30', $this->form_data['lname'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-last' ).'\' )', 'maxlength' => '25', 'id' => 'lname' ) ) . '</td>';
	278	+ $form .= '<td>' . Xml::input( 'fname', '30', $this->form_data['fname'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-donor-fname' ).'\' )', 'maxlength' => '25', 'class' => 'required', 'id' => 'fname' ) ) .
	279	+ Xml::input( 'lname', '30', $this->form_data['lname'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-donor-lname' ).'\' )', 'maxlength' => '25', 'id' => 'lname' ) ) . '</td>';
280	280	$form .= "</tr>";
281	281
282	282	// street
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnPremiumUS.php
—	—	@@ -15,8 +15,8 @@
16	16	public function loadPlaceholders() {
17	17	global $wgOut;
18	18	// form placeholder values
19		~~- $first = wfMsg( 'payflowpro_gateway-first' );~~
20		~~- $last = wfMsg( 'payflowpro_gateway-last' );~~
	19	+ $first = wfMsg( 'payflowpro_gateway-donor-fname' );
	20	+ $last = wfMsg( 'payflowpro_gateway-donor-lname' );
21	21	$street = wfMsg( 'payflowpro_gateway-donor-street' );
22	22	$city = wfMsg( 'payflowpro_gateway-donor-city' );
23	23	$zip = wfMsg( 'payflowpro_gateway-zip-code' );
—	—	@@ -252,8 +252,8 @@
253	253	$form .= '</tr>';
254	254	$form .= '<tr>';
255	255	$form .= '<td class="label">' . Xml::label( wfMsg( 'payflowpro_gateway-name-on-card' ), 'fname' ) . '</td>';
256		- $form .= '<td>' . Xml::input( 'fname', '30', $this->form_data['fname'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-first' ).'\' )', 'maxlength' => '25', 'class' => 'required', 'id' => 'fname' ) ) .
257		- Xml::input( 'lname', '30', $this->form_data['lname'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-last' ).'\' )', 'maxlength' => '25', 'id' => 'lname' ) ) . '</td>';
	256	+ $form .= '<td>' . Xml::input( 'fname', '30', $this->form_data['fname'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-donor-fname' ).'\' )', 'maxlength' => '25', 'class' => 'required', 'id' => 'fname' ) ) .
	257	+ Xml::input( 'lname', '30', $this->form_data['lname'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-donor-lname' ).'\' )', 'maxlength' => '25', 'id' => 'lname' ) ) . '</td>';
258	258	$form .= "</tr>";
259	259
260	260	// street
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/OneStepTwoColumn.php
—	—	@@ -22,8 +22,8 @@
23	23	public function loadPlaceholders() {
24	24	global $wgOut;
25	25	// form placeholder values
26		~~- $first = wfMsg( 'payflowpro_gateway-first' );~~
27		~~- $last = wfMsg( 'payflowpro_gateway-last' );~~
	26	+ $first = wfMsg( 'payflowpro_gateway-donor-fname' );
	27	+ $last = wfMsg( 'payflowpro_gateway-donor-lname' );
28	28	$other = wfMsg( 'payflowpro_gateway-other' );
29	29	$js = <<<EOT
30	30	<script type="text/javascript">

Status & tagging log

23:46, 19 May 2011 Reedy (talk | contribs) changed the status of r80551 [removed: new added: deferred]