r80549 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80548‎ | r80549 | r80550 >
Date:01:46, 19 January 2011
Author:laner
Status:deferred
Tags:
Comment:
Uncommenting code that was commented for testing.
Modified paths:
  • /trunk/extensions/OpenStackManager/OpenStackNovaController.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/OpenStackNovaController.php
@@ -137,11 +137,11 @@
138138 $options['InstanceType'] = $instanceType;
139139 $options['Placement.AvailabilityZone'] = $availabilityZone;
140140 $options['DisplayName'] = $instanceName;
141 - #if ( count( $groups ) > 1 ) {
 141+ if ( count( $groups ) > 1 ) {
142142 $options['SecurityGroup'] = $groups;
143 - #} else if ( count( $groups ) == 1 ) {
144 - # $options['SecurityGroup'] = $groups[0];
145 - #}
 143+ } else if ( count( $groups ) == 1 ) {
 144+ $options['SecurityGroup'] = $groups[0];
 145+ }
146146 $response = $this->novaConnection->run_instances( $image, 1, 1, $options );
147147 if ( ! $response->isOK() ) {
148148 return null;

Status & tagging log