r80502 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80501‎ | r80502 | r80503 >
Date:17:56, 18 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r79262, isset() around keyId, and switch uniqueKey to using it's own name, rather than keyId...
Modified paths:
  • /trunk/extensions/Renameuser/RenameUserJob.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Renameuser/RenameUserJob.php
@@ -30,8 +30,8 @@
3131 $timestampColumn = isset( $this->params['timestampColumn'] ) ? $this->params['timestampColumn'] : null;
3232 $minTimestamp = $this->params['minTimestamp'];
3333 $maxTimestamp = $this->params['maxTimestamp'];
34 - $uniqueKey = isset( $this->params['keyId'] ) ? $this->params['keyId'] : null;
35 - $keyId = $this->params['keyId'];
 34+ $uniqueKey = isset( $this->params['uniqueKey'] ) ? $this->params['uniqueKey'] : null;
 35+ $keyId = isset( $this->params['keyId'] ) ? $this->params['keyId'] : null;
3636 $newname = $this->params['newname'];
3737 $count = $this->params['count'];
3838

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79262Swap extract for explicit variable definitionsreedy16:40, 30 December 2010

Status & tagging log