r80468 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80467‎ | r80468 | r80469 >
Date:21:42, 17 January 2011
Author:platonides
Status:ok
Tags:
Comment:
Follow up r80205 define rename in check-vars and files added in r80443 and r80466.
Modified paths:
  • /trunk/phase3/maintenance/language/generateCollationData.php (modified) (history)
  • /trunk/phase3/maintenance/preprocessDump.php (modified) (history)
  • /trunk/tools/code-utils/check-vars.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/generateCollationData.php
@@ -377,5 +377,5 @@
378378 }
379379
380380 $maintClass = 'GenerateCollationData';
381 -require_once( DO_MAINTENANCE );
 381+require_once( RUN_MAINTENANCE_IF_MAIN );
382382
Index: trunk/phase3/maintenance/preprocessDump.php
@@ -144,5 +144,5 @@
145145 }
146146
147147 $maintClass = "PreprocessDump";
148 -require_once( DO_MAINTENANCE );
 148+require_once( RUN_MAINTENANCE_IF_MAIN );
149149
Index: trunk/tools/code-utils/check-vars.php
@@ -649,7 +649,7 @@
650650 //$this->warning( "require uses unknown variable {$token[1]} in line {$token[2]}" );
651651 $requirePath .= $token[1];
652652 }
653 - } elseif ( $token[0] == T_STRING && $token[1] == 'DO_MAINTENANCE' ) {
 653+ } elseif ( $token[0] == T_STRING && $token[1] == 'RUN_MAINTENANCE_IF_MAIN' ) {
654654 $requirePath .= "$IP/maintenance/doMaintenance.php";
655655 } elseif ( $token[0] == T_STRING && $token[1] == 'MW_CONFIG_FILE' ) {
656656 $requirePath .= "$IP/LocalSettings.php";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80205Fix concern raised by Brion in r74108 (but has really existed since the maint...demon22:58, 13 January 2011
r80443* Introduced a non-dummy collation for $wgCategoryCollation, namely UCA with ...tstarling14:02, 17 January 2011
r80466preprocessDump.php maintenance script.platonides21:29, 17 January 2011

Status & tagging log