r80405 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80404‎ | r80405 | r80406 >
Date:16:07, 15 January 2011
Author:ialex
Status:ok
Tags:
Comment:
Added wfDeprecated() to Article::insertNewArticle() and Article::updateArticle(). The last usage of these two methods was removed in r80402.
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -1941,11 +1941,11 @@
19421942 }
19431943
19441944 /**
1945 - * This function is not deprecated until somebody fixes the core not to use
1946 - * it. Nevertheless, use Article::doEdit() instead.
1947 - * @deprecated @since 1.7
 1945+ * @deprecated @since 1.7 use Article::doEdit()
19481946 */
19491947 function insertNewArticle( $text, $summary, $isminor, $watchthis, $suppressRC = false, $comment = false, $bot = false ) {
 1948+ wfDeprecated( __METHOD__ );
 1949+
19501950 $flags = EDIT_NEW | EDIT_DEFER_UPDATES | EDIT_AUTOSUMMARY |
19511951 ( $isminor ? EDIT_MINOR : 0 ) |
19521952 ( $suppressRC ? EDIT_SUPPRESS_RC : 0 ) |
@@ -1978,6 +1978,8 @@
19791979 * @deprecated @since 1.7 use Article::doEdit()
19801980 */
19811981 function updateArticle( $text, $summary, $minor, $watchthis, $forceBot = false, $sectionanchor = '' ) {
 1982+ wfDeprecated( __METHOD__ );
 1983+
19821984 $flags = EDIT_UPDATE | EDIT_DEFER_UPDATES | EDIT_AUTOSUMMARY |
19831985 ( $minor ? EDIT_MINOR : 0 ) |
19841986 ( $forceBot ? EDIT_FORCE_BOT : 0 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80402Modified EditPage to use Article::doEdit() instead of Article::insertNewArtic...ialex15:21, 15 January 2011

Status & tagging log