r80352 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80351‎ | r80352 | r80353 >
Date:23:29, 14 January 2011
Author:krinkle
Status:deferred
Tags:
Comment:
jquery modal boxes are z-index are 1000. since the suggestions were showing behind the modal giving it a higher z-index; fixing 404 error to loader image when search.php is $.fn.load() (relativepath -> absolutepath)
Modified paths:
  • /trunk/tools/wp-photocommons/css/jquery.suggestions.css (modified) (history)
  • /trunk/tools/wp-photocommons/search.php (modified) (history)

Diff [purge]

Index: trunk/tools/wp-photocommons/css/jquery.suggestions.css
@@ -7,7 +7,7 @@
88 left: 0px;
99 width: 0px;
1010 border: none;
11 - z-index: 99;
 11+ z-index: 1099;
1212 padding: 0;
1313 margin: -1px -1px 0 0;
1414 }
Index: trunk/tools/wp-photocommons/search.php
@@ -1,11 +1,14 @@
2 -<?php $standalone = empty($_GET['standalone']); ?>
3 -<?php if ($standalone) : ?>
 2+<?php
 3+$dir = dirname($_SERVER['PHP_SELF']);
 4+$standalone = empty($_GET['standalone']);
 5+
 6+if ($standalone) : ?>
47 <!doctype html>
58 <html>
69 <head>
710 <meta charset="utf-8" />
8 - <link rel="stylesheet" href="css/ui-lightness/jquery-ui-1.8.5.custom.css" />
9 - <link rel="stylesheet" href="css/jquery.suggestions.css" />
 11+ <link rel="stylesheet" href="<?=$dir?>/css/ui-lightness/jquery-ui-1.8.5.custom.css" />
 12+ <link rel="stylesheet" href="<?=$dir?>/css/jquery.suggestions.css" />
1013 </head>
1114 <body>
1215 <?php endif; ?>
@@ -15,15 +18,15 @@
1619
1720 <ul id="wp-photocommons-results"></ul>
1821
19 - <img src="img/loading.gif" style="display:none;" id="wp-photocommons-loading" />
 22+ <img src="<?=$dir?>/img/loading.gif" style="display:none;" id="wp-photocommons-loading" />
2023
2124 <div id="wp-photocommons-images"></div>
2225
2326 <?php if ($standalone) : ?>
2427 <script src="http://ajax.googleapis.com/ajax/libs/jquery/1.4.4/jquery.min.js"></script>
25 - <script src="js/jquery-ui-1.8.5.custom.min.js"></script>
26 - <script src="js/search.js"></script>
27 - <script src="js/jquery.suggestions.js"></script>
 28+ <script src="<?=$dir?>/js/jquery-ui-1.8.5.custom.min.js"></script>
 29+ <script src="<?=$dir?>/js/search.js"></script>
 30+ <script src="<?=$dir?>/js/jquery.suggestions.js"></script>
2831 </body>
2932 </html>
30 -<?php endif; ?>
\ No newline at end of file
 33+<?php endif; ?>

Status & tagging log