r80303 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80302‎ | r80303 | r80304 >
Date:19:25, 14 January 2011
Author:hartman
Status:deferred
Tags:
Comment:
Update projects settings with latest iOS settings.
Use org.wikimedia.commons identifiers
Modified paths:
  • /trunk/tools/Snap-to-Commons/photopicker-Info.plist (modified) (history)
  • /trunk/tools/Snap-to-Commons/photopicker.xcodeproj/project.pbxproj (modified) (history)

Diff [purge]

Index: trunk/tools/Snap-to-Commons/photopicker.xcodeproj/project.pbxproj
@@ -165,11 +165,18 @@
166166 29B97313FDCFA39411CA2CEA /* Project object */ = {
167167 isa = PBXProject;
168168 attributes = {
169 - ORGANIZATIONNAME = yourcompanyname;
 169+ ORGANIZATIONNAME = "Wikimedia Commons";
170170 };
171171 buildConfigurationList = C01FCF4E08A954540054247B /* Build configuration list for PBXProject "photopicker" */;
172172 compatibilityVersion = "Xcode 3.1";
 173+ developmentRegion = English;
173174 hasScannedForEncodings = 1;
 175+ knownRegions = (
 176+ English,
 177+ Japanese,
 178+ French,
 179+ German,
 180+ );
174181 mainGroup = 29B97314FDCFA39411CA2CEA /* CustomTemplate */;
175182 projectDirPath = "";
176183 projectRoot = "";
@@ -232,14 +239,14 @@
233240 buildSettings = {
234241 ARCHS = "$(ARCHS_STANDARD_32_BIT)";
235242 CODE_SIGN_IDENTITY = "Don't Code Sign";
236 - "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "Don't Code Sign";
 243+ "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
237244 GCC_C_LANGUAGE_STANDARD = c99;
238245 GCC_WARN_ABOUT_RETURN_TYPE = YES;
239246 GCC_WARN_UNUSED_VARIABLE = YES;
240247 PREBINDING = NO;
241248 PROVISIONING_PROFILE = "";
242249 "PROVISIONING_PROFILE[sdk=iphoneos*]" = "";
243 - SDKROOT = iphoneos3.0;
 250+ SDKROOT = iphoneos;
244251 };
245252 name = Debug;
246253 };
Index: trunk/tools/Snap-to-Commons/photopicker-Info.plist
@@ -7,13 +7,13 @@
88 <key>CFBundleDevelopmentRegion</key>
99 <string>English</string>
1010 <key>CFBundleDisplayName</key>
11 - <string>yourappname</string>
 11+ <string>Snap-to-Commons</string>
1212 <key>CFBundleExecutable</key>
1313 <string>${EXECUTABLE_NAME}</string>
1414 <key>CFBundleIconFile</key>
1515 <string>icon.png</string>
1616 <key>CFBundleIdentifier</key>
17 - <string>com.yourcompanyname.${PRODUCT_NAME:rfc1034identifier}</string>
 17+ <string>org.wikimedia.commons.${PRODUCT_NAME:rfc1034identifier}</string>
1818 <key>CFBundleInfoDictionaryVersion</key>
1919 <string>6.0</string>
2020 <key>CFBundleName</key>
@@ -28,20 +28,5 @@
2929 <true/>
3030 <key>NSMainNibFile</key>
3131 <string>MainWindow</string>
32 - <key>CFBundleURLTypes</key>
33 - <array>
34 - <dict>
35 - <key>CFBundleURLName</key>
36 - <string>com.yourcompanyname.photopicker</string>
37 - <key>CFBundleTypeRole</key>
38 - <string>Editor</string>
39 - <key>CFBundleURLIconFile</key>
40 - <string>icon</string>
41 - <key>CFBundleURLSchemes</key>
42 - <array>
43 - <string>photopicker</string>
44 - </array>
45 - </dict>
46 - </array>
4732 </dict>
4833 </plist>

Status & tagging log