r80290 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80289‎ | r80290 | r80291 >
Date:18:42, 14 January 2011
Author:catrope
Status:ok
Tags:license-work 
Comment:
license-work: After discussion with Krinkle and Bryan, remove rev_fileprops_id and rename fp_id to fp_rev_id
Modified paths:
  • /branches/license-work/phase3/maintenance/tables.sql (modified) (history)

Diff [purge]

Index: branches/license-work/phase3/maintenance/tables.sql
@@ -307,12 +307,7 @@
308308
309309 -- Key to revision.rev_id
310310 -- This field is used to add support for a tree structure (The Adjacency List Model)
311 - rev_parent_id int unsigned default NULL,
312 -
313 - -- Key to file_props.fp_id
314 - -- For revisions with no associated file properties, this is NULL
315 - rev_fileprops_id int unsigned default NULL
316 -
 311+ rev_parent_id int unsigned default NULL
317312 ) /*$wgDBTableOptions*/ MAX_ROWS=10000000 AVG_ROW_LENGTH=1024;
318313 -- In case tables are created as MyISAM, use row hints for MySQL <5.0 to avoid 4GB limit
319314
@@ -1451,12 +1446,12 @@
14521447 CREATE INDEX /*i*/lic_count ON /*_*/license (lic_count);
14531448
14541449 -- Table for tracking file properties
 1450+-- Each file revision (fp_rev_id) can have multiple rows in this table,
14551451 -- allowing for multiple properties and multiple values for each property.
14561452 -- Properties can have a numerical value, a text value, or both.
14571453 CREATE TABLE /*_*/file_props (
1458 - -- File property ID. This is the same for each row referring to the same file revision
1459 - fp_id int unsigned NOT NULL,
 1454+ -- Revision these properties apply to. Key to revision.rev_id
 1455+ fp_rev_id int unsigned NOT NULL,
14601456 -- Property key
14611457 fp_key varbinary(255) NOT NULL,
14621458 -- Numerical property value, if present

Follow-up revisions

RevisionCommit summaryAuthorDate
r80291Follow-up to r80282, r80290: Revert changes to Revision.php; allow saving propsbtongminh18:43, 14 January 2011
r80311Fix r80290: change field name in index toocatrope20:20, 14 January 2011
r80343After even more discussion with Krinkle and Bryan, add rev_fileprops_id back ...catrope22:48, 14 January 2011

Status & tagging log