r80279 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80278‎ | r80279 | r80280 >
Date:16:44, 14 January 2011
Author:dale
Status:deferred
Tags:
Comment:
bug 26722 increase the height from the bottom of the player that we display the subtitle text
Modified paths:
  • /branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/mw.PlayerControlBuilder.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/TimedText/mw.TimedText.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/mw.PlayerControlBuilder.js
@@ -707,7 +707,7 @@
708708 .fadeOut( animateDuration );
709709 //mw.log('about to trigger hide control bar')
710710 // Allow interface items to update:
711 - $j( this.embedPlayer ).trigger('onHideControlBar', {'bottom' : 10} );
 711+ $j( this.embedPlayer ).trigger('onHideControlBar', {'bottom' : 15} );
712712
713713 },
714714
@@ -728,7 +728,7 @@
729729 .fadeIn( animateDuration );
730730
731731 // Trigger the screen overlay with layout info:
732 - $j( this.embedPlayer ).trigger( 'onShowControlBar', {'bottom' : this.getHeight() + 10 } );
 732+ $j( this.embedPlayer ).trigger( 'onShowControlBar', {'bottom' : this.getHeight() + 15 } );
733733 },
734734
735735 /**
Index: branches/MwEmbedStandAlone/modules/TimedText/mw.TimedText.js
@@ -148,7 +148,7 @@
149149
150150 // Resize the timed text font size per window width
151151 $j( embedPlayer ).bind( 'onCloseFullScreen onOpenFullScreen', function() {
152 - var textOffset = _this.embedPlayer.controlBuilder.fullscreenMode ? 30 : 10;
 152+ var textOffset = _this.embedPlayer.controlBuilder.fullscreenMode ? 35 : 15;
153153
154154 mw.log( 'TimedText::set text size for: : ' + embedPlayer.$interface.width() + ' = ' + _this.getInterfaceSizeTextCss({
155155 'width' : embedPlayer.$interface.width(),
@@ -188,7 +188,7 @@
189189 embedPlayer.$interface.find( '.track' )
190190 .stop()
191191 .animate( layout, 'fast' );
192 - });
 192+ });
193193
194194 },
195195 /**
@@ -1084,7 +1084,7 @@
10851085 })
10861086 ).css({
10871087 'line-height' : '1.6em'
1088 - })
 1088+ });
10891089
10901090 $playerTarget.append( $track );
10911091

Status & tagging log