r80184 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80183‎ | r80184 | r80185 >
Date:19:04, 13 January 2011
Author:demon
Status:ok
Tags:
Comment:
Revert r76676: per IRC with Brion, this might not be complete, should skip deployment for now to be safe
Modified paths:
  • /branches/REL1_17/extensions/CentralAuth/CentralAuthPlugin.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/extensions/CentralAuth/CentralAuthPlugin.php
@@ -109,9 +109,7 @@
110110 */
111111 function updateUser( &$user ) {
112112 $central = CentralAuthUser::getInstance( $user );
113 - if ( $central->exists() && $central->isAttached() &&
114 - $central->getEmail() != $user->getEmail() )
115 - {
 113+ if ( $central->exists() && $central->isAttached() ) {
116114 $user->setEmail( $central->getEmail() );
117115 $user->mEmailAuthenticated = $central->getEmailAuthenticationTimestamp();
118116 $user->saveSettings();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76676Only invalidate the user cache if the e-mail address actually changed. First ...demon22:16, 14 November 2010

Status & tagging log