r80173 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80172‎ | r80173 | r80174 >
Date:16:57, 13 January 2011
Author:yaron
Status:deferred
Tags:
Comment:
Removed 'sfgAdderButtons' global PHP/JS variable - no longer necessary
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormUtils.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_Settings.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormUtils.php
@@ -10,11 +10,10 @@
1111
1212 class SFFormUtils {
1313 static function setGlobalJSVariables( &$vars ) {
14 - global $sfgAdderButtons, $sfgShowOnSelect;
1514 global $sfgAutocompleteValues, $sfgAutocompleteOnAllChars;
 15+ global $sfgShowOnSelect;
1616
1717 $vars['sfgRemoveText'] = wfMsg( 'sf_formedit_remove' );
18 - $vars['sfgAdderButtons'] = $sfgAdderButtons;
1918 $vars['sfgAutocompleteOnAllChars'] = $sfgAutocompleteOnAllChars;
2019 // variables that are associative arrays need to be cast as
2120 // objects, to work with MW 1.15 and earlier
Index: trunk/extensions/SemanticForms/includes/SF_Settings.php
@@ -117,6 +117,5 @@
118118 # ##
119119 # Global variables for Javascript
120120 # ##
121 -$sfgAdderButtons = array();
122121 $sfgShowOnSelect = array();
123122 $sfgAutocompleteValues = array();

Status & tagging log