r80152 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80151‎ | r80152 | r80153 >
Date:02:56, 13 January 2011
Author:kaldari
Status:deferred
Tags:
Comment:
dont have to be paranoid since only wikis with thank you pages allow arbitrary html
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNotice.php (modified) (history)
  • /trunk/extensions/CentralNotice/SpecialHideBanners.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/CentralNotice.php
@@ -64,10 +64,6 @@
6565 // This setting is currently shared with CentralAuth extension.
6666 $wgCentralAuthCookieDomain = '';
6767
68 -// Enable HideBanners Special Page
69 -// Set to true on wikis with donation thank you pages.
70 -$wgAllowHideBanners = false;
71 -
7268 $wgExtensionFunctions[] = 'efCentralNoticeSetup';
7369
7470 $wgExtensionCredits['other'][] = array(
Index: trunk/extensions/CentralNotice/SpecialHideBanners.php
@@ -13,8 +13,8 @@
1414 }
1515
1616 function execute( $par ) {
17 - global $wgAllowHideBanners, $wgRequest, $wgOut;
18 -
 17+ global $wgOut;
 18+
1919 $this->setHideCookie();
2020
2121 $wgOut->disable();

Status & tagging log