r80148 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80147‎ | r80148 | r80149 >
Date:01:15, 13 January 2011
Author:kaldari
Status:deferred
Tags:
Comment:
preventing misuse again
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNotice.php (modified) (history)
  • /trunk/extensions/CentralNotice/SpecialHideBanners.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/CentralNotice.php
@@ -66,7 +66,7 @@
6767
6868 // Enable HideBanners Special Page
6969 // Set to true on wikis with donation thank you pages.
70 -$wgAllowHideBanners = 'false';
 70+$wgAllowHideBanners = false;
7171
7272 $wgExtensionFunctions[] = 'efCentralNoticeSetup';
7373
Index: trunk/extensions/CentralNotice/SpecialHideBanners.php
@@ -17,13 +17,13 @@
1818
1919 if ( $wgAllowHideBanners ) {
2020 $this->setHideCookie();
21 -
 21+
2222 $wgOut->disable();
2323 wfResetOutputBuffers();
24 -
 24+
2525 header( 'Content-Type: image/png' );
2626 header( 'Cache-Control: no-cache' );
27 -
 27+
2828 readfile( dirname( __FILE__ ) . '/1x1.png' );
2929 }
3030 }

Status & tagging log