r8012 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r8011‎ | r8012 | r8013 >
Date:12:35, 31 March 2005
Author:avar
Status:old
Tags:
Comment:
++Precision
Modified paths:
  • /trunk/phase3/includes/SpecialUpload.php (modified) (history)
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialUpload.php
@@ -233,7 +233,7 @@
234234 if ( $wgUploadSizeWarning && ( $this->mUploadSize > $wgUploadSizeWarning ) ) {
235235 # TODO: Format $wgUploadSizeWarning to something that looks better than the raw byte
236236 # value, perhaps add GB,MB and KB suffixes?
237 - $warning .= '<li>'.wfMsg( 'largefile', $wgUploadSizeWarning ).'</li>';
 237+ $warning .= '<li>'.wfMsg( 'largefile', $wgUploadSizeWarning, $this->mUploadSize ).'</li>';
238238 }
239239 if ( $this->mUploadSize == 0 ) {
240240 $warning .= '<li>'.wfMsg( 'emptyfile' ).'</li>';
Index: trunk/phase3/languages/Language.php
@@ -1011,7 +1011,7 @@
10121012 'illegalfilename' => 'The filename "$1" contains characters that are not allowed in page titles. Please rename the file and try uploading it again.',
10131013 'badfilename' => "Image name has been changed to \"$1\".",
10141014 'badfiletype' => "\".$1\" is not a recommended image file format.",
1015 -'largefile' => 'It is recommended that images not exceed $1 bytes in size.',
 1015+'largefile' => 'It is recommended that images not exceed $1 bytes in size, this file is $2 bytes',
10161016 'emptyfile' => 'The file you uploaded seems to be empty. This might be due to a typo in the file name. Please check whether you really want to upload this file.',
10171017 'fileexists' => 'A file with this name exists already, please check $1 if you are not sure if you want to change it.',
10181018 'successfulupload' => 'Successful upload',

Status & tagging log