r80104 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80103‎ | r80104 | r80105 >
Date:19:03, 12 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Per CR on r75575, remove array_keys() as getModuleNames has array_key'd the returned stuffs
Modified paths:
  • /trunk/phase3/maintenance/cleanupRemovedModules.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/cleanupRemovedModules.php
@@ -37,7 +37,7 @@
3838 public function execute() {
3939 $dbw = wfGetDB( DB_MASTER );
4040 $rl = new ResourceLoader();
41 - $moduleNames = array_keys( $rl->getModuleNames() );
 41+ $moduleNames = $rl->getModuleNames();
4242 $moduleList = implode( ', ', array_map( array( $dbw, 'addQuotes' ), $moduleNames ) );
4343 $limit = max( 1, intval( $this->getOption( 'batchsize', 500 ) ) );
4444 $maxlag = intval( $this->getOption( 'max-slave-lag', 5 ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r801751.17: MFT r79960, r80034, r80036, r80043, r80044, r80050, r80053, r80074, r80...catrope17:13, 13 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75575Re-add maintenance script from r75555, not totally broken this timecatrope20:08, 27 October 2010

Status & tagging log