r80056 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80055‎ | r80056 | r80057 >
Date:23:35, 11 January 2011
Author:laner
Status:deferred
Tags:
Comment:
* Fixing a bug with creating domains when an empty location field is set
* Adding a help message for location field for domain creation
Modified paths:
  • /trunk/extensions/OpenStackManager/OpenStackManager.i18n.php (modified) (history)
  • /trunk/extensions/OpenStackManager/OpenStackNovaDomain.php (modified) (history)
  • /trunk/extensions/OpenStackManager/special/SpecialNovaDomain.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/special/SpecialNovaDomain.php
@@ -64,6 +64,7 @@
6565 'label-message' => 'openstackmanager-location',
6666 'default' => '',
6767 'section' => 'domain/info',
 68+ 'help-message' => 'openstackmanager-location-help',
6869 );
6970 $domainInfo['action'] = array(
7071 'type' => 'hidden',
Index: trunk/extensions/OpenStackManager/OpenStackManager.i18n.php
@@ -60,6 +60,7 @@
6161 'openstackmanager-domainname' => 'Domain Name',
6262 'openstackmanager-fqdn' => 'Fully Qualified Domain Name',
6363 'openstackmanager-location' => 'Location',
 64+ 'openstackmanager-location-help' => 'Location field is for private DNS zones. Leave blank for public zones.',
6465
6566 'openstackmanager-novainstance-instance' => 'Instance',
6667 'openstackmanager-configureinstance' => 'Configure Instance',
Index: trunk/extensions/OpenStackManager/OpenStackNovaDomain.php
@@ -181,7 +181,9 @@
182182 $domain['dc'] = $domainname;
183183 $domain['soarecord'] = $wgOpenStackManagerDNSOptions['servers']['primary'] . ' ' . $soa;
184184 $domain['associateddomain'] = $fqdn;
185 - $domain['l'] = $location;
 185+ if ( $location ) {
 186+ $domain['l'] = $location;
 187+ }
186188 $dn = 'dc=' . $domainname . ',' . $wgOpenStackManagerLDAPInstanceBaseDN;
187189
188190 wfSuppressWarnings();

Status & tagging log