r79981 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79980‎ | r79981 | r79982 >
Date:00:11, 11 January 2011
Author:awjrichards
Status:deferred
Tags:
Comment:
Updated references to contact id to use key of 'contact_id' rather than just 'id'
Modified paths:
  • /civicrm/trunk/sites/all/modules/queue2civicrm/queue2civicrm.module (modified) (history)
  • /civicrm/trunk/sites/all/modules/queue2civicrm/queue2civicrm_common.inc (modified) (history)
  • /civicrm/trunk/sites/all/modules/queue2civicrm/recurring/recurring.module (modified) (history)

Diff [purge]

Index: civicrm/trunk/sites/all/modules/queue2civicrm/recurring/recurring.module
@@ -232,7 +232,7 @@
233233 //dsm($contribution);
234234 watchdog('queue2civicrm', 'Contribution:<pre>' . check_plain(print_r($msg, TRUE)) . '</pre>');
235235
236 - $contact[ 'id' ] = $recur_record->contact_id;
 236+ $contact[ 'contact_id' ] = $recur_record->contact_id;
237237
238238 //insert the contribution
239239 $contribution = _queue2civicrm_contribution_insert( $msg, $contact, $recur_record->id );
@@ -250,7 +250,7 @@
251251 // construct an array of useful info to invocations of queue2civicrm_import
252252 $contribution_info = array(
253253 'contribution_id' => $contribution['id'],
254 - 'contact_id' => $contact['id'],
 254+ 'contact_id' => $contact[ 'contact_id' ],
255255 'msg' => $msg,
256256 );
257257
Index: civicrm/trunk/sites/all/modules/queue2civicrm/queue2civicrm_common.inc
@@ -170,7 +170,7 @@
171171 require_once 'api/v2/Location.php';
172172
173173 $address = array(
174 - 'contact_id' => $contact['id'],
 174+ 'contact_id' => $contact[ 'contact_id' ],
175175 'location_type' => 'Home',
176176 'street_address' => $msg['street_address'],
177177 'supplemental_address_1' => $msg['supplemental_address_1'],
@@ -201,7 +201,7 @@
202202 require_once 'api/v2/Location.php';
203203
204204 $address = array(
205 - 'contact_id' => $contact['id'],
 205+ 'contact_id' => $contact[ 'contact_id' ],
206206 'street_address' => $msg['street_address'],
207207 'supplemental_address_1' => $msg['supplemental_address_1'],
208208 'city' => $msg['city'],
@@ -230,7 +230,7 @@
231231
232232 // Insert the contribution record
233233 $contribution = array(
234 - 'contact_id' => $contact['id'],
 234+ 'contact_id' => $contact[ 'contact_id' ],
235235 'total_amount' => $msg['gross'],
236236 'contribution_type_id' => 9, // cash donation @fixme this needs to be pulled from a variable that was available with fundcore, but no longer exists
237237 'payment_instrument_id' => 6, // contribution @fixme see above
@@ -299,7 +299,7 @@
300300
301301 $tag = array(
302302 'tag_id' => 7, // review tag @fixme should this also be variable?
303 - 'contact_id' => $contact['id']
 303+ 'contact_id' => $contact[ 'contact_id' ]
304304 );
305305 $tag_result = &civicrm_entity_tag_add( $tag );
306306 return $tag_result;
Index: civicrm/trunk/sites/all/modules/queue2civicrm/queue2civicrm.module
@@ -207,7 +207,7 @@
208208 // construct an array of useful info to invocations of queue2civicrm_import
209209 $contribution_info = array(
210210 'contribution_id' => $contribution['id'],
211 - 'contact_id' => $contact['id'],
 211+ 'contact_id' => $contact['contact_id'],
212212 'msg' => $msg,
213213 );
214214

Status & tagging log