r79898 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79897‎ | r79898 | r79899 >
Date:15:27, 9 January 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r78988
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_List.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_List.php
@@ -111,8 +111,9 @@
112112 $rows_in_cur_column = 0;
113113 }
114114
115 - if ( strlen($header) > 0 )
 115+ if ( $header != '' ) {
116116 $result .= "\t\t\t\t$header\n";
 117+ }
117118
118119 if ( $this->mIntroTemplate != '' ) {
119120 $result .= "{{" . $this->mIntroTemplate . "}}";
@@ -137,8 +138,9 @@
138139 }
139140
140141 // Print footer
141 - if ( strlen($footer) > 0 )
 142+ if ( $footer != '' ) {
142143 $result .= "\t\t\t\t$footer\n";
 144+ }
143145
144146 if ( $this->mColumns > 1 ) {
145147 $result .= "\t\t\t\t</div>\n";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78988These newlines are causing rendering bugs in existing SMW installations upgra...dantman02:12, 25 December 2010

Status & tagging log