r79781 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79780‎ | r79781 | r79782 >
Date:00:46, 7 January 2011
Author:yaron
Status:deferred
Tags:
Comment:
Removed referencing ("&") from variables passed in - not needed, and causes warnings in some PHP versions
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormClasses.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormClasses.php
@@ -117,7 +117,7 @@
118118 foreach ( $matches[1] as $i => $field_name ) {
119119 if ( ! in_array( $field_name, $fieldNamesArray ) ) {
120120 $propertyName = $matches[2][$i];
121 - self::handlePropertySettingInTemplate( $field_name, $propertyName, true, &$templateFields, $templateText );
 121+ self::handlePropertySettingInTemplate( $field_name, $propertyName, true, $templateFields, $templateText );
122122 $fieldNamesArray[] = $field_name;
123123 }
124124 }
@@ -129,7 +129,7 @@
130130 $field_name = trim( $matches[2][$i] );
131131 if ( ! in_array( $field_name, $fieldNamesArray ) ) {
132132 $propertyName = trim( $propertyName );
133 - self::handlePropertySettingInTemplate( $field_name, $propertyName, false, &$templateFields, $templateText );
 133+ self::handlePropertySettingInTemplate( $field_name, $propertyName, false, $templateFields, $templateText );
134134 $fieldNamesArray[] = $field_name;
135135 }
136136 }
@@ -144,7 +144,7 @@
145145 $fieldName = trim( $matches2[2][$i] );
146146 if ( ! in_array( $fieldName, $fieldNamesArray ) ) {
147147 $propertyName = trim( $propertyName );
148 - self::handlePropertySettingInTemplate( $fieldName, $propertyName, false, &$templateFields, $templateText );
 148+ self::handlePropertySettingInTemplate( $fieldName, $propertyName, false, $templateFields, $templateText );
149149 $fieldNamesArray[] = $fieldName;
150150 }
151151 }
@@ -162,7 +162,7 @@
163163 $propertyName = trim( $keyAndVal[0] );
164164 $fieldName = trim( $keyAndVal[1] );
165165 if ( ! in_array( $fieldName, $fieldNamesArray ) ) {
166 - self::handlePropertySettingInTemplate( $fieldName, $propertyName, false, &$templateFields, $templateText );
 166+ self::handlePropertySettingInTemplate( $fieldName, $propertyName, false, $templateFields, $templateText );
167167 $fieldNamesArray[] = $fieldName;
168168 }
169169 }

Status & tagging log