r79744 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79743‎ | r79744 | r79745 >
Date:19:15, 6 January 2011
Author:platonides
Status:ok
Tags:
Comment:
Follow up r78786. Do not mark as @deprecated yet, since it is called by getQueryInfo().
Modified paths:
  • /trunk/phase3/includes/QueryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/QueryPage.php
@@ -135,9 +135,9 @@
136136 * For back-compat, subclasses may return a raw SQL query here, as a string.
137137 * This is stronly deprecated; getQueryInfo() should be overridden instead.
138138 * @return string
139 - * @deprecated since 1.18
140139 */
141140 function getSQL() {
 141+ /* Implement getQueryInfo() instead */
142142 throw new MWException( "Bug in a QueryPage: doesn't implement getQueryInfo() nor getQuery() properly" );
143143 }
144144

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78786Merge querypage-work2 branch from trunk. The most relevant changes are:...catrope14:16, 22 December 2010

Status & tagging log