r79730 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79729‎ | r79730 | r79731 >
Date:16:51, 6 January 2011
Author:mkroetzsch
Status:deferred
Tags:
Comment:
extended documentation to clarify that internal units are not the same as the output format, even if our implementation allows unit conversion to be set by selecting an output format; the difference shows in RDF export where the selected output format has no effect on the exported data (since the underlying data is always the same)
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Number.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Number.php
@@ -20,6 +20,13 @@
2121 * before being processed. All units, IDs or otherwise, should be suitable for
2222 * printout in wikitext, and main IDs should moreover be suitable for printout
2323 * in HTML.
 24+ *
 25+ * Subclasses that support unit conversion may interpret the output format set
 26+ * via setOutputFormat() to allow a unit to be selected for display. Note that
 27+ * this setting does not affect the internal representation of the value
 28+ * though. So chosing a specific output format will change the behavior of
 29+ * output functions like getLongWikiText(), but not of functions that access
 30+ * the value itself, such as getUnit() or getDBKeys().
2431 *
2532 * @author Markus Krötzsch
2633 * @ingroup SMWDataValues

Status & tagging log