r79726 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79725‎ | r79726 | r79727 >
Date:15:55, 6 January 2011
Author:happy-melon
Status:ok
Tags:
Comment:
More documentation formatting
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -5,19 +5,19 @@
66 */
77
88 /**
9 - * \int Number of characters in user_token field.
 9+ * Int Number of characters in user_token field.
1010 * @ingroup Constants
1111 */
1212 define( 'USER_TOKEN_LENGTH', 32 );
1313
1414 /**
15 - * \int Serialized record version.
 15+ * Int Serialized record version.
1616 * @ingroup Constants
1717 */
1818 define( 'MW_USER_VERSION', 8 );
1919
2020 /**
21 - * \string Some punctuation to prevent editing from broken text-mangling proxies.
 21+ * String Some punctuation to prevent editing from broken text-mangling proxies.
2222 * @ingroup Constants
2323 */
2424 define( 'EDIT_TOKEN_SUFFIX', '+\\' );
@@ -50,7 +50,7 @@
5151 const EDIT_TOKEN_SUFFIX = EDIT_TOKEN_SUFFIX;
5252
5353 /**
54 - * \type{\arrayof{\string}} List of member variables which are saved to the
 54+ * Array of Strings List of member variables which are saved to the
5555 * shared cache (memcached). Any operation which changes the
5656 * corresponding database fields must call a cache-clearing function.
5757 * @showinitializer
@@ -78,7 +78,7 @@
7979 );
8080
8181 /**
82 - * \type{\arrayof{\string}} Core rights.
 82+ * Array of Strings Core rights.
8383 * Each of these should have a corresponding message of the form
8484 * "right-$right".
8585 * @showinitializer
@@ -140,7 +140,7 @@
141141 'writeapi',
142142 );
143143 /**
144 - * \string Cached results of getAllRights()
 144+ * String Cached results of getAllRights()
145145 */
146146 static $mAllRights = false;
147147
@@ -152,12 +152,12 @@
153153 //@}
154154
155155 /**
156 - * \bool Whether the cache variables have been loaded.
 156+ * Bool Whether the cache variables have been loaded.
157157 */
158158 var $mDataLoaded, $mAuthLoaded, $mOptionsLoaded;
159159
160160 /**
161 - * \string Initialization data source if mDataLoaded==false. May be one of:
 161+ * String Initialization data source if mDataLoaded==false. May be one of:
162162 * - 'defaults' anonymous user initialised from class defaults
163163 * - 'name' initialise from mName
164164 * - 'id' initialise from mId
@@ -167,12 +167,12 @@
168168 */
169169 var $mFrom;
170170
171 - /** @name Lazy-initialized variables, invalidated with clearInstanceCache */
172 - //@{
 171+ /**
 172+ * Lazy-initialized variables, invalidated with clearInstanceCache
 173+ */
173174 var $mNewtalk, $mDatePreference, $mBlockedby, $mHash, $mSkin, $mRights,
174175 $mBlockreason, $mBlock, $mEffectiveGroups, $mBlockedGlobally,
175176 $mLocked, $mHideName, $mOptions;
176 - //@}
177177
178178 static $idCacheByName = array();
179179
@@ -230,7 +230,7 @@
231231
232232 /**
233233 * Load user table data, given mId has already been set.
234 - * @return \bool false if the ID does not exist, true otherwise
 234+ * @return Bool false if the ID does not exist, true otherwise
235235 * @private
236236 */
237237 function loadFromId() {
@@ -297,12 +297,12 @@
298298 * This is slightly less efficient than newFromId(), so use newFromId() if
299299 * you have both an ID and a name handy.
300300 *
301 - * @param $name \string Username, validated by Title::newFromText()
302 - * @param $validate \mixed Validate username. Takes the same parameters as
 301+ * @param $name String Username, validated by Title::newFromText()
 302+ * @param $validate String|Bool Validate username. Takes the same parameters as
303303 * User::getCanonicalName(), except that true is accepted as an alias
304304 * for 'valid', for BC.
305305 *
306 - * @return User The User object, or false if the username is invalid
 306+ * @return User object, or false if the username is invalid
307307 * (e.g. if it contains illegal characters or is an IP address). If the
308308 * username is not present in the database, the result will be a user object
309309 * with a name, zero user ID and default settings.
@@ -326,8 +326,8 @@
327327 /**
328328 * Static factory method for creation from a given user ID.
329329 *
330 - * @param $id \int Valid user ID
331 - * @return \type{User} The corresponding User object
 330+ * @param $id Int Valid user ID
 331+ * @return User The corresponding User object
332332 */
333333 static function newFromId( $id ) {
334334 $u = new User;
@@ -343,8 +343,8 @@
344344 *
345345 * If the code is invalid or has expired, returns NULL.
346346 *
347 - * @param $code \string Confirmation code
348 - * @return \type{User}
 347+ * @param $code String Confirmation code
 348+ * @return User
349349 */
350350 static function newFromConfirmationCode( $code ) {
351351 $dbr = wfGetDB( DB_SLAVE );
@@ -363,7 +363,7 @@
364364 * Create a new user object using data from session or cookies. If the
365365 * login credentials are invalid, the result is an anonymous user.
366366 *
367 - * @return \type{User}
 367+ * @return User
368368 */
369369 static function newFromSession() {
370370 $user = new User;
@@ -374,8 +374,8 @@
375375 /**
376376 * Create a new user object from a user row.
377377 * The row should have all fields from the user table in it.
378 - * @param $row array A row from the user table
379 - * @return \type{User}
 378+ * @param $row Array A row from the user table
 379+ * @return User
380380 */
381381 static function newFromRow( $row ) {
382382 $user = new User;
@@ -388,8 +388,8 @@
389389
390390 /**
391391 * Get the username corresponding to a given user ID
392 - * @param $id \int User ID
393 - * @return \string The corresponding username
 392+ * @param $id Int User ID
 393+ * @return String The corresponding username
394394 */
395395 static function whoIs( $id ) {
396396 $dbr = wfGetDB( DB_SLAVE );
@@ -399,8 +399,8 @@
400400 /**
401401 * Get the real name of a user given their user ID
402402 *
403 - * @param $id \int User ID
404 - * @return \string The corresponding user's real name
 403+ * @param $id Int User ID
 404+ * @return String The corresponding user's real name
405405 */
406406 static function whoIsReal( $id ) {
407407 $dbr = wfGetDB( DB_SLAVE );
@@ -409,8 +409,8 @@
410410
411411 /**
412412 * Get database id given a user name
413 - * @param $name \string Username
414 - * @return \types{\int,\null} The corresponding user's ID, or null if user is nonexistent
 413+ * @param $name String Username
 414+ * @return Int|Null The corresponding user's ID, or null if user is nonexistent
415415 */
416416 static function idFromName( $name ) {
417417 $nt = Title::makeTitleSafe( NS_USER, $name );
@@ -454,8 +454,8 @@
455455 * addresses like this, if we allowed accounts like this to be created
456456 * new users could get the old edits of these anonymous users.
457457 *
458 - * @param $name \string String to match
459 - * @return \bool True or false
 458+ * @param $name String to match
 459+ * @return Bool
460460 */
461461 static function isIP( $name ) {
462462 return preg_match('/^\d{1,3}\.\d{1,3}\.\d{1,3}\.(?:xxx|\d{1,3})$/',$name) || IP::isIPv6($name);
@@ -469,8 +469,8 @@
470470 * is longer than the maximum allowed username size or doesn't begin with
471471 * a capital letter.
472472 *
473 - * @param $name \string String to match
474 - * @return \bool True or false
 473+ * @param $name String to match
 474+ * @return Bool
475475 */
476476 static function isValidUserName( $name ) {
477477 global $wgContLang, $wgMaxNameChars;
@@ -523,8 +523,8 @@
524524 * If an account already exists in this form, login will be blocked
525525 * by a failure to pass this function.
526526 *
527 - * @param $name \string String to match
528 - * @return \bool True or false
 527+ * @param $name String to match
 528+ * @return Bool
529529 */
530530 static function isUsableName( $name ) {
531531 global $wgReservedUsernames;
@@ -560,8 +560,8 @@
561561 * Additional blacklisting may be added here rather than in
562562 * isValidUserName() to avoid disrupting existing accounts.
563563 *
564 - * @param $name \string String to match
565 - * @return \bool True or false
 564+ * @param $name String to match
 565+ * @return Bool
566566 */
567567 static function isCreatableName( $name ) {
568568 global $wgInvalidUsernameCharacters;
@@ -588,7 +588,7 @@
589589 * Is the input a valid password for this user?
590590 *
591591 * @param $password String Desired password
592 - * @return bool True or false
 592+ * @return Bool
593593 */
594594 function isValidPassword( $password ) {
595595 //simple boolean wrapper for getPasswordValidity
@@ -644,8 +644,8 @@
645645 *
646646 * @todo Check for RFC 2822 compilance (bug 959)
647647 *
648 - * @param $addr \string E-mail address
649 - * @return \bool True or false
 648+ * @param $addr String E-mail address
 649+ * @return Bool
650650 */
651651 public static function isValidEmailAddr( $addr ) {
652652 $result = null;
@@ -670,8 +670,8 @@
671671 /**
672672 * Given unvalidated user input, return a canonical username, or false if
673673 * the username is invalid.
674 - * @param $name \string User input
675 - * @param $validate \types{\string,\bool} Type of validation to use:
 674+ * @param $name String User input
 675+ * @param $validate String|Bool type of validation to use:
676676 * - false No validation
677677 * - 'valid' Valid for batch processes
678678 * - 'usable' Valid for batch processes and login
@@ -728,8 +728,8 @@
729729 * Count the number of edits of a user
730730 * @todo It should not be static and some day should be merged as proper member function / deprecated -- domas
731731 *
732 - * @param $uid \int User ID to check
733 - * @return \int The user's edit count
 732+ * @param $uid Int User ID to check
 733+ * @return Int the user's edit count
734734 */
735735 static function edits( $uid ) {
736736 wfProfileIn( __METHOD__ );
@@ -765,7 +765,7 @@
766766 * Return a random password. Sourced from mt_rand, so it's not particularly secure.
767767 * @todo hash random numbers to improve security, like generateToken()
768768 *
769 - * @return \string New random password
 769+ * @return String new random password
770770 */
771771 static function randomPassword() {
772772 global $wgMinimalPasswordLength;
@@ -831,7 +831,7 @@
832832 /**
833833 * Load user data from the session or login cookie. If there are no valid
834834 * credentials, initialises the user as an anonymous user.
835 - * @return \bool True if the user is logged in, false otherwise.
 835+ * @return Bool True if the user is logged in, false otherwise.
836836 */
837837 private function loadFromSession() {
838838 global $wgRequest, $wgExternalAuthType, $wgAutocreatePolicy;
@@ -922,7 +922,7 @@
923923 * Load user and user_group data from the database.
924924 * $this::mId must be set, this is how the user is identified.
925925 *
926 - * @return \bool True if the user exists, false if the user is anonymous
 926+ * @return Bool True if the user exists, false if the user is anonymous
927927 * @private
928928 */
929929 function loadFromDatabase() {
@@ -957,7 +957,7 @@
958958 /**
959959 * Initialize this object from a row from the user table.
960960 *
961 - * @param $row \type{\arrayof{\mixed}} Row from the user table to load.
 961+ * @param $row Array Row from the user table to load.
962962 */
963963 function loadFromRow( $row ) {
964964 $this->mDataLoaded = true;
@@ -1001,7 +1001,7 @@
10021002
10031003 /**
10041004 * Clear various cached data stored in this object.
1005 - * @param $reloadFrom \string Reload user and user_groups table data from a
 1005+ * @param $reloadFrom String Reload user and user_groups table data from a
10061006 * given source. May be "name", "id", "defaults", "session", or false for
10071007 * no reload.
10081008 */
@@ -1025,7 +1025,7 @@
10261026 * Combine the language default options with any site-specific options
10271027 * and add the default language variants.
10281028 *
1029 - * @return \type{\arrayof{\string}} Array of options
 1029+ * @return Array of String options
10301030 */
10311031 static function getDefaultOptions() {
10321032 global $wgNamespacesToBeSearchedDefault;
@@ -1052,8 +1052,8 @@
10531053 /**
10541054 * Get a given default option value.
10551055 *
1056 - * @param $opt \string Name of option to retrieve
1057 - * @return \string Default option value
 1056+ * @param $opt String Name of option to retrieve
 1057+ * @return String Default option value
10581058 */
10591059 public static function getDefaultOption( $opt ) {
10601060 $defOpts = self::getDefaultOptions();
@@ -1068,7 +1068,7 @@
10691069 /**
10701070 * Get blocking information
10711071 * @private
1072 - * @param $bFromSlave \bool Whether to check the slave database first. To
 1072+ * @param $bFromSlave Bool Whether to check the slave database first. To
10731073 * improve performance, non-critical checks are done
10741074 * against slaves. Check when actually saving should be
10751075 * done against master.
@@ -1160,9 +1160,9 @@
11611161 /**
11621162 * Whether the given IP is in a DNS blacklist.
11631163 *
1164 - * @param $ip \string IP to check
1165 - * @param $checkWhitelist Boolean: whether to check the whitelist first
1166 - * @return \bool True if blacklisted.
 1164+ * @param $ip String IP to check
 1165+ * @param $checkWhitelist Bool: whether to check the whitelist first
 1166+ * @return Bool True if blacklisted.
11671167 */
11681168 function isDnsBlacklisted( $ip, $checkWhitelist = false ) {
11691169 global $wgEnableSorbs, $wgEnableDnsBlacklist,
@@ -1181,9 +1181,9 @@
11821182 /**
11831183 * Whether the given IP is in a given DNS blacklist.
11841184 *
1185 - * @param $ip \string IP to check
1186 - * @param $bases \string or Array of Strings: URL of the DNS blacklist
1187 - * @return \bool True if blacklisted.
 1185+ * @param $ip String IP to check
 1186+ * @param $bases String|Array of Strings: URL of the DNS blacklist
 1187+ * @return Bool True if blacklisted.
11881188 */
11891189 function inDnsBlacklist( $ip, $bases ) {
11901190 wfProfileIn( __METHOD__ );
@@ -1218,7 +1218,7 @@
12191219 /**
12201220 * Is this user subject to rate limiting?
12211221 *
1222 - * @return \bool True if rate limited
 1222+ * @return Bool True if rate limited
12231223 */
12241224 public function isPingLimitable() {
12251225 global $wgRateLimitsExcludedGroups;
@@ -1243,8 +1243,8 @@
12441244 * @note When using a shared cache like memcached, IP-address
12451245 * last-hit counters will be shared across wikis.
12461246 *
1247 - * @param $action \string Action to enforce; 'edit' if unspecified
1248 - * @return \bool True if a rate limiter was tripped
 1247+ * @param $action String Action to enforce; 'edit' if unspecified
 1248+ * @return Bool True if a rate limiter was tripped
12491249 */
12501250 function pingLimiter( $action = 'edit' ) {
12511251 # Call the 'PingLimiter' hook
@@ -1336,8 +1336,8 @@
13371337 /**
13381338 * Check if user is blocked
13391339 *
1340 - * @param $bFromSlave \bool Whether to check the slave database instead of the master
1341 - * @return \bool True if blocked, false otherwise
 1340+ * @param $bFromSlave Bool Whether to check the slave database instead of the master
 1341+ * @return Bool True if blocked, false otherwise
13421342 */
13431343 function isBlocked( $bFromSlave = true ) { // hacked from false due to horrible probs on site
13441344 $this->getBlockedStatus( $bFromSlave );
@@ -1347,9 +1347,9 @@
13481348 /**
13491349 * Check if user is blocked from editing a particular article
13501350 *
1351 - * @param $title \string Title to check
1352 - * @param $bFromSlave \bool Whether to check the slave database instead of the master
1353 - * @return \bool True if blocked, false otherwise
 1351+ * @param $title Title to check
 1352+ * @param $bFromSlave Bool whether to check the slave database instead of the master
 1353+ * @return Bool
13541354 */
13551355 function isBlockedFrom( $title, $bFromSlave = false ) {
13561356 global $wgBlockAllowsUTEdit;
@@ -1372,7 +1372,7 @@
13731373
13741374 /**
13751375 * If user is blocked, return the name of the user who placed the block
1376 - * @return \string name of blocker
 1376+ * @return String name of blocker
13771377 */
13781378 function blockedBy() {
13791379 $this->getBlockedStatus();
@@ -1381,7 +1381,7 @@
13821382
13831383 /**
13841384 * If user is blocked, return the specified reason for the block
1385 - * @return \string Blocking reason
 1385+ * @return String Blocking reason
13861386 */
13871387 function blockedFor() {
13881388 $this->getBlockedStatus();
@@ -1390,7 +1390,7 @@
13911391
13921392 /**
13931393 * If user is blocked, return the ID for the block
1394 - * @return \int Block ID
 1394+ * @return Int Block ID
13951395 */
13961396 function getBlockId() {
13971397 $this->getBlockedStatus();
@@ -1402,8 +1402,8 @@
14031403 * Do not use for actual edit permission checks!
14041404 * This is intented for quick UI checks.
14051405 *
1406 - * @param $ip \type{\string} IP address, uses current client if none given
1407 - * @return \type{\bool} True if blocked, false otherwise
 1406+ * @param $ip String IP address, uses current client if none given
 1407+ * @return Bool True if blocked, false otherwise
14081408 */
14091409 function isBlockedGlobally( $ip = '' ) {
14101410 if( $this->mBlockedGlobally !== null ) {
@@ -1424,7 +1424,7 @@
14251425 /**
14261426 * Check if user account is locked
14271427 *
1428 - * @return \type{\bool} True if locked, false otherwise
 1428+ * @return Bool True if locked, false otherwise
14291429 */
14301430 function isLocked() {
14311431 if( $this->mLocked !== null ) {
@@ -1439,7 +1439,7 @@
14401440 /**
14411441 * Check if user account is hidden
14421442 *
1443 - * @return \type{\bool} True if hidden, false otherwise
 1443+ * @return Bool True if hidden, false otherwise
14441444 */
14451445 function isHidden() {
14461446 if( $this->mHideName !== null ) {
@@ -1456,7 +1456,7 @@
14571457
14581458 /**
14591459 * Get the user's ID.
1460 - * @return Integer The user's ID; 0 if the user is anonymous or nonexistent
 1460+ * @return Int The user's ID; 0 if the user is anonymous or nonexistent
14611461 */
14621462 function getId() {
14631463 if( $this->mId === null and $this->mName !== null
@@ -1472,7 +1472,7 @@
14731473
14741474 /**
14751475 * Set the user and reload all fields according to a given ID
1476 - * @param $v \int User ID to reload
 1476+ * @param $v Int User ID to reload
14771477 */
14781478 function setId( $v ) {
14791479 $this->mId = $v;
@@ -1481,7 +1481,7 @@
14821482
14831483 /**
14841484 * Get the user name, or the IP of an anonymous user
1485 - * @return \string User's name or IP address
 1485+ * @return String User's name or IP address
14861486 */
14871487 function getName() {
14881488 if ( !$this->mDataLoaded && $this->mFrom == 'name' ) {
@@ -1508,7 +1508,7 @@
15091509 *
15101510 * @note User::newFromName() has rougly the same function, when the named user
15111511 * does not exist.
1512 - * @param $str \string New user name to set
 1512+ * @param $str String New user name to set
15131513 */
15141514 function setName( $str ) {
15151515 $this->load();
@@ -1517,7 +1517,7 @@
15181518
15191519 /**
15201520 * Get the user's name escaped by underscores.
1521 - * @return \string Username escaped by underscores.
 1521+ * @return String Username escaped by underscores.
15221522 */
15231523 function getTitleKey() {
15241524 return str_replace( ' ', '_', $this->getName() );
@@ -1525,7 +1525,7 @@
15261526
15271527 /**
15281528 * Check if the user has new messages.
1529 - * @return \bool True if the user has new messages
 1529+ * @return Bool True if the user has new messages
15301530 */
15311531 function getNewtalk() {
15321532 $this->load();
@@ -1558,7 +1558,7 @@
15591559
15601560 /**
15611561 * Return the talk page(s) this user has new messages on.
1562 - * @return \type{\arrayof{\string}} Array of page URLs
 1562+ * @return Array of String page URLs
15631563 */
15641564 function getNewMessageLinks() {
15651565 $talks = array();
@@ -1576,10 +1576,10 @@
15771577 * Internal uncached check for new messages
15781578 *
15791579 * @see getNewtalk()
1580 - * @param $field \string 'user_ip' for anonymous users, 'user_id' otherwise
1581 - * @param $id \types{\string,\int} User's IP address for anonymous users, User ID otherwise
1582 - * @param $fromMaster \bool true to fetch from the master, false for a slave
1583 - * @return \bool True if the user has new messages
 1580+ * @param $field String 'user_ip' for anonymous users, 'user_id' otherwise
 1581+ * @param $id String|Int User's IP address for anonymous users, User ID otherwise
 1582+ * @param $fromMaster Bool true to fetch from the master, false for a slave
 1583+ * @return Bool True if the user has new messages
15841584 * @private
15851585 */
15861586 function checkNewtalk( $field, $id, $fromMaster = false ) {
@@ -1595,9 +1595,9 @@
15961596
15971597 /**
15981598 * Add or update the new messages flag
1599 - * @param $field \string 'user_ip' for anonymous users, 'user_id' otherwise
1600 - * @param $id \types{\string,\int} User's IP address for anonymous users, User ID otherwise
1601 - * @return \bool True if successful, false otherwise
 1599+ * @param $field String 'user_ip' for anonymous users, 'user_id' otherwise
 1600+ * @param $id String|Int User's IP address for anonymous users, User ID otherwise
 1601+ * @return Bool True if successful, false otherwise
16021602 * @private
16031603 */
16041604 function updateNewtalk( $field, $id ) {
@@ -1617,9 +1617,9 @@
16181618
16191619 /**
16201620 * Clear the new messages flag for the given user
1621 - * @param $field \string 'user_ip' for anonymous users, 'user_id' otherwise
1622 - * @param $id \types{\string,\int} User's IP address for anonymous users, User ID otherwise
1623 - * @return \bool True if successful, false otherwise
 1621+ * @param $field String 'user_ip' for anonymous users, 'user_id' otherwise
 1622+ * @param $id String|Int User's IP address for anonymous users, User ID otherwise
 1623+ * @return Bool True if successful, false otherwise
16241624 * @private
16251625 */
16261626 function deleteNewtalk( $field, $id ) {
@@ -1638,7 +1638,7 @@
16391639
16401640 /**
16411641 * Update the 'You have new messages!' status.
1642 - * @param $val \bool Whether the user has new messages
 1642+ * @param $val Bool Whether the user has new messages
16431643 */
16441644 function setNewtalk( $val ) {
16451645 if( wfReadOnly() ) {
@@ -1677,7 +1677,7 @@
16781678 /**
16791679 * Generate a current or new-future timestamp to be stored in the
16801680 * user_touched field when we update things.
1681 - * @return \string Timestamp in TS_MW format
 1681+ * @return String Timestamp in TS_MW format
16821682 */
16831683 private static function newTouchedTimestamp() {
16841684 global $wgClockSkewFudge;
@@ -1724,7 +1724,7 @@
17251725
17261726 /**
17271727 * Validate the cache for this account.
1728 - * @param $timestamp \string A timestamp in TS_MW format
 1728+ * @param $timestamp String A timestamp in TS_MW format
17291729 */
17301730 function validateCache( $timestamp ) {
17311731 $this->load();
@@ -1733,6 +1733,7 @@
17341734
17351735 /**
17361736 * Get the user touched timestamp
 1737+ * @return String timestamp
17371738 */
17381739 function getTouched() {
17391740 $this->load();
@@ -1750,7 +1751,7 @@
17511752 * wipes it, so the account cannot be logged in until
17521753 * a new password is set, for instance via e-mail.
17531754 *
1754 - * @param $str \string New password to set
 1755+ * @param $str String New password to set
17551756 * @throws PasswordError on failure
17561757 */
17571758 function setPassword( $str ) {
@@ -1781,7 +1782,7 @@
17821783 /**
17831784 * Set the password and reset the random token unconditionally.
17841785 *
1785 - * @param $str \string New password to set
 1786+ * @param $str String New password to set
17861787 */
17871788 function setInternalPassword( $str ) {
17881789 $this->load();
@@ -1799,7 +1800,7 @@
18001801
18011802 /**
18021803 * Get the user's current token.
1803 - * @return \string Token
 1804+ * @return String Token
18041805 */
18051806 function getToken() {
18061807 $this->load();
@@ -1810,7 +1811,7 @@
18111812 * Set the random token (used for persistent authentication)
18121813 * Called from loadDefaults() among other places.
18131814 *
1814 - * @param $token \string If specified, set the token to this value
 1815+ * @param $token String If specified, set the token to this value
18151816 * @private
18161817 */
18171818 function setToken( $token = false ) {
@@ -1833,7 +1834,7 @@
18341835 /**
18351836 * Set the cookie password
18361837 *
1837 - * @param $str \string New cookie password
 1838+ * @param $str String New cookie password
18381839 * @private
18391840 */
18401841 function setCookiePassword( $str ) {
@@ -1844,8 +1845,8 @@
18451846 /**
18461847 * Set the password for a password reminder or new account email
18471848 *
1848 - * @param $str \string New password to set
1849 - * @param $throttle \bool If true, reset the throttle timestamp to the present
 1849+ * @param $str String New password to set
 1850+ * @param $throttle Bool If true, reset the throttle timestamp to the present
18501851 */
18511852 function setNewpassword( $str, $throttle = true ) {
18521853 $this->load();
@@ -1858,7 +1859,7 @@
18591860 /**
18601861 * Has password reminder email been sent within the last
18611862 * $wgPasswordReminderResendTime hours?
1862 - * @return \bool True or false
 1863+ * @return Bool
18631864 */
18641865 function isPasswordReminderThrottled() {
18651866 global $wgPasswordReminderResendTime;
@@ -1872,7 +1873,7 @@
18731874
18741875 /**
18751876 * Get the user's e-mail address
1876 - * @return \string User's email address
 1877+ * @return String User's email address
18771878 */
18781879 function getEmail() {
18791880 $this->load();
@@ -1882,7 +1883,7 @@
18831884
18841885 /**
18851886 * Get the timestamp of the user's e-mail authentication
1886 - * @return \string TS_MW timestamp
 1887+ * @return String TS_MW timestamp
18871888 */
18881889 function getEmailAuthenticationTimestamp() {
18891890 $this->load();
@@ -1892,7 +1893,7 @@
18931894
18941895 /**
18951896 * Set the user's e-mail address
1896 - * @param $str \string New e-mail address
 1897+ * @param $str String New e-mail address
18971898 */
18981899 function setEmail( $str ) {
18991900 $this->load();
@@ -1902,7 +1903,7 @@
19031904
19041905 /**
19051906 * Get the user's real name
1906 - * @return \string User's real name
 1907+ * @return String User's real name
19071908 */
19081909 function getRealName() {
19091910 $this->load();
@@ -1911,7 +1912,7 @@
19121913
19131914 /**
19141915 * Set the user's real name
1915 - * @param $str \string New real name
 1916+ * @param $str String New real name
19161917 */
19171918 function setRealName( $str ) {
19181919 $this->load();
@@ -1921,9 +1922,9 @@
19221923 /**
19231924 * Get the user's current setting for a given option.
19241925 *
1925 - * @param $oname \string The option to check
1926 - * @param $defaultOverride \string A default value returned if the option does not exist
1927 - * @return \string User's current value for the option
 1926+ * @param $oname String The option to check
 1927+ * @param $defaultOverride String A default value returned if the option does not exist
 1928+ * @return String User's current value for the option
19281929 * @see getBoolOption()
19291930 * @see getIntOption()
19301931 */
@@ -1957,8 +1958,8 @@
19581959 /**
19591960 * Get the user's current setting for a given option, as a boolean value.
19601961 *
1961 - * @param $oname \string The option to check
1962 - * @return \bool User's current value for the option
 1962+ * @param $oname String The option to check
 1963+ * @return Bool User's current value for the option
19631964 * @see getOption()
19641965 */
19651966 function getBoolOption( $oname ) {
@@ -1969,9 +1970,9 @@
19701971 /**
19711972 * Get the user's current setting for a given option, as a boolean value.
19721973 *
1973 - * @param $oname \string The option to check
1974 - * @param $defaultOverride \int A default value returned if the option does not exist
1975 - * @return \int User's current value for the option
 1974+ * @param $oname String The option to check
 1975+ * @param $defaultOverride Int A default value returned if the option does not exist
 1976+ * @return Int User's current value for the option
19761977 * @see getOption()
19771978 */
19781979 function getIntOption( $oname, $defaultOverride=0 ) {
@@ -1985,8 +1986,8 @@
19861987 /**
19871988 * Set the given option for a user.
19881989 *
1989 - * @param $oname \string The option to set
1990 - * @param $val \mixed New value to set
 1990+ * @param $oname String The option to set
 1991+ * @param $val mixed New value to set
19911992 */
19921993 function setOption( $oname, $val ) {
19931994 $this->load();
@@ -2015,7 +2016,7 @@
20162017
20172018 /**
20182019 * Get the user's preferred date format.
2019 - * @return \string User's preferred date format
 2020+ * @return String User's preferred date format
20202021 */
20212022 function getDatePreference() {
20222023 // Important migration for old data rows
@@ -2047,7 +2048,7 @@
20482049
20492050 /**
20502051 * Get the permissions this user has.
2051 - * @return \type{\arrayof{\string}} Array of permission names
 2052+ * @return Array of String permission names
20522053 */
20532054 function getRights() {
20542055 if ( is_null( $this->mRights ) ) {
@@ -2062,7 +2063,7 @@
20632064 /**
20642065 * Get the list of explicit group memberships this user has.
20652066 * The implicit * and user groups are not included.
2066 - * @return \type{\arrayof{\string}} Array of internal group names
 2067+ * @return Array of String internal group names
20672068 */
20682069 function getGroups() {
20692070 $this->load();
@@ -2072,9 +2073,9 @@
20732074 /**
20742075 * Get the list of implicit group memberships this user has.
20752076 * This includes all explicit groups, plus 'user' if logged in,
2076 - * '*' for all accounts and autopromoted groups
2077 - * @param $recache \bool Whether to avoid the cache
2078 - * @return \type{\arrayof{\string}} Array of internal group names
 2077+ * '*' for all accounts, and autopromoted groups
 2078+ * @param $recache Bool Whether to avoid the cache
 2079+ * @return Array of String internal group names
20792080 */
20802081 function getEffectiveGroups( $recache = false ) {
20812082 if ( $recache || is_null( $this->mEffectiveGroups ) ) {
@@ -2099,7 +2100,7 @@
21002101
21012102 /**
21022103 * Get the user's edit count.
2103 - * @return \int User'e edit count
 2104+ * @return Int
21042105 */
21052106 function getEditCount() {
21062107 if( $this->getId() ) {
@@ -2117,7 +2118,7 @@
21182119 /**
21192120 * Add the user to the given group.
21202121 * This takes immediate effect.
2121 - * @param $group \string Name of the group to add
 2122+ * @param $group String Name of the group to add
21222123 */
21232124 function addGroup( $group ) {
21242125 $dbw = wfGetDB( DB_MASTER );
@@ -2141,7 +2142,7 @@
21422143 /**
21432144 * Remove the user from the given group.
21442145 * This takes immediate effect.
2145 - * @param $group \string Name of the group to remove
 2146+ * @param $group String Name of the group to remove
21462147 */
21472148 function removeGroup( $group ) {
21482149 $this->load();
@@ -2161,7 +2162,7 @@
21622163
21632164 /**
21642165 * Get whether the user is logged in
2165 - * @return \bool True or false
 2166+ * @return Bool
21662167 */
21672168 function isLoggedIn() {
21682169 return $this->getID() != 0;
@@ -2169,7 +2170,7 @@
21702171
21712172 /**
21722173 * Get whether the user is anonymous
2173 - * @return \bool True or false
 2174+ * @return Bool
21742175 */
21752176 function isAnon() {
21762177 return !$this->isLoggedIn();
@@ -2177,8 +2178,8 @@
21782179
21792180 /**
21802181 * Get whether the user is a bot
2181 - * @return \bool True or false
2182 - * @deprecated
 2182+ * @return Bool
 2183+ * @deprecated use isAllowed('bot')
21832184 */
21842185 function isBot() {
21852186 wfDeprecated( __METHOD__ );
@@ -2187,7 +2188,7 @@
21882189
21892190 /**
21902191 * Check if user is allowed to access a feature / make an action
2191 - * @param $action \string action to be checked
 2192+ * @param $action String action to be checked
21922193 * @return Boolean: True if action is allowed, else false
21932194 */
21942195 function isAllowed( $action = '' ) {
@@ -2216,7 +2217,7 @@
22172218
22182219 /**
22192220 * Check whether to enable new pages patrol features for this user
2220 - * @return \bool True or false
 2221+ * @return Bool True or false
22212222 */
22222223 public function useNPPatrol() {
22232224 global $wgUseRCPatrol, $wgUseNPPatrol;
@@ -2227,7 +2228,7 @@
22282229 * Get the current skin, loading it if required, and setting a title
22292230 * @param $t Title: the title to use in the skin
22302231 * @return Skin The current skin
2231 - * @todo FIXME : need to check the old failback system [AV]
 2232+ * @todo: FIXME : need to check the old failback system [AV]
22322233 */
22332234 function getSkin( $t = null ) {
22342235 if ( $t ) {
@@ -2273,8 +2274,8 @@
22742275
22752276 /**
22762277 * Check the watched status of an article.
2277 - * @param $title \type{Title} Title of the article to look at
2278 - * @return \bool True if article is watched
 2278+ * @param $title Title of the article to look at
 2279+ * @return Bool
22792280 */
22802281 function isWatched( $title ) {
22812282 $wl = WatchedItem::fromUserTitle( $this, $title );
@@ -2283,7 +2284,7 @@
22842285
22852286 /**
22862287 * Watch an article.
2287 - * @param $title \type{Title} Title of the article to look at
 2288+ * @param $title Title of the article to look at
22882289 */
22892290 function addWatch( $title ) {
22902291 $wl = WatchedItem::fromUserTitle( $this, $title );
@@ -2293,7 +2294,7 @@
22942295
22952296 /**
22962297 * Stop watching an article.
2297 - * @param $title \type{Title} Title of the article to look at
 2298+ * @param $title Title of the article to look at
22982299 */
22992300 function removeWatch( $title ) {
23002301 $wl = WatchedItem::fromUserTitle( $this, $title );
@@ -2305,7 +2306,7 @@
23062307 * Clear the user's notification timestamp for the given title.
23072308 * If e-notif e-mails are on, they will receive notification mails on
23082309 * the next change of the page if it's watched etc.
2309 - * @param $title \type{Title} Title of the article to look at
 2310+ * @param $title Title of the article to look at
23102311 */
23112312 function clearNotification( &$title ) {
23122313 global $wgUser, $wgUseEnotif, $wgShowUpdatedMarker;
@@ -2366,7 +2367,7 @@
23672368 * If e-notif e-mails are on, they will receive notification mails on
23682369 * the next change of any watched page.
23692370 *
2370 - * @param $currentUser \int User ID
 2371+ * @param $currentUser Int User ID
23712372 */
23722373 function clearAllNotifications( $currentUser ) {
23732374 global $wgUseEnotif, $wgShowUpdatedMarker;
@@ -2390,7 +2391,7 @@
23912392
23922393 /**
23932394 * Set this user's options from an encoded string
2394 - * @param $str \string Encoded options to import
 2395+ * @param $str String Encoded options to import
23952396 * @private
23962397 */
23972398 function decodeOptions( $str ) {
@@ -2416,9 +2417,9 @@
24172418 /**
24182419 * Set a cookie on the user's client. Wrapper for
24192420 * WebResponse::setCookie
2420 - * @param $name \string Name of the cookie to set
2421 - * @param $value \string Value to set
2422 - * @param $exp \int Expiration time, as a UNIX time value;
 2421+ * @param $name String Name of the cookie to set
 2422+ * @param $value String Value to set
 2423+ * @param $exp Int Expiration time, as a UNIX time value;
24232424 * if 0 or not specified, use the default $wgCookieExpiration
24242425 */
24252426 protected function setCookie( $name, $value, $exp = 0 ) {
@@ -2428,7 +2429,7 @@
24292430
24302431 /**
24312432 * Clear a cookie on the user's client
2432 - * @param $name \string Name of the cookie to clear
 2433+ * @param $name String Name of the cookie to clear
24332434 */
24342435 protected function clearCookie( $name ) {
24352436 $this->setCookie( $name, '', time() - 86400 );
@@ -2535,6 +2536,7 @@
25362537
25372538 /**
25382539 * If only this user's username is known, and it exists, return the user ID.
 2540+ * @return Int
25392541 */
25402542 function idForName() {
25412543 $s = trim( $this->getName() );
@@ -2551,8 +2553,8 @@
25522554 /**
25532555 * Add a user to the database, return the user object
25542556 *
2555 - * @param $name \string Username to add
2556 - * @param $params \type{\arrayof{\string}} Non-default parameters to save to the database:
 2557+ * @param $name String Username to add
 2558+ * @param $params Array of Strings Non-default parameters to save to the database:
25572559 * - password The user's password. Password logins will be disabled if this is omitted.
25582560 * - newpassword A temporary password mailed to the user
25592561 * - email The user's email address
@@ -2562,7 +2564,7 @@
25632565 * - token Random authentication token. Do not set.
25642566 * - registration Registration timestamp. Do not set.
25652567 *
2566 - * @return \type{User} A new User object, or null if the username already exists
 2568+ * @return User object, or null if the username already exists
25672569 */
25682570 static function createNew( $name, $params = array() ) {
25692571 $user = new User;
@@ -2662,7 +2664,7 @@
26632665 * settings.
26642666 *
26652667 * @deprecated use the ParserOptions object to get the relevant options
2666 - * @return \string Page rendering hash
 2668+ * @return String Page rendering hash
26672669 */
26682670 function getPageRenderingHash() {
26692671 global $wgUseDynamicDates, $wgRenderHashAppend, $wgLang, $wgContLang;
@@ -2704,7 +2706,7 @@
27052707
27062708 /**
27072709 * Get whether the user is explicitly blocked from account creation.
2708 - * @return \bool True if blocked
 2710+ * @return Bool
27092711 */
27102712 function isBlockedFromCreateAccount() {
27112713 $this->getBlockedStatus();
@@ -2713,7 +2715,7 @@
27142716
27152717 /**
27162718 * Get whether the user is blocked from using Special:Emailuser.
2717 - * @return Boolean: True if blocked
 2719+ * @return Bool
27182720 */
27192721 function isBlockedFromEmailuser() {
27202722 $this->getBlockedStatus();
@@ -2722,7 +2724,7 @@
27232725
27242726 /**
27252727 * Get whether the user is allowed to create an account.
2726 - * @return Boolean: True if allowed
 2728+ * @return Bool
27272729 */
27282730 function isAllowedToCreateAccount() {
27292731 return $this->isAllowed( 'createaccount' ) && !$this->isBlockedFromCreateAccount();
@@ -2766,7 +2768,7 @@
27672769 /**
27682770 * Determine whether the user is a newbie. Newbies are either
27692771 * anonymous IPs, or the most recently created accounts.
2770 - * @return Boolean: True if the user is a newbie
 2772+ * @return Bool
27712773 */
27722774 function isNewbie() {
27732775 return !$this->isAllowed( 'autoconfirmed' );
@@ -2836,8 +2838,8 @@
28372839 * login credentials aren't being hijacked with a foreign form
28382840 * submission.
28392841 *
2840 - * @param $salt \types{\string,\arrayof{\string}} Optional function-specific data for hashing
2841 - * @return \string The new edit token
 2842+ * @param $salt String|Array of Strings Optional function-specific data for hashing
 2843+ * @return String The new edit token
28422844 */
28432845 function editToken( $salt = '' ) {
28442846 if ( $this->isAnon() ) {
@@ -2859,8 +2861,8 @@
28602862 /**
28612863 * Generate a looking random token for various uses.
28622864 *
2863 - * @param $salt \string Optional salt value
2864 - * @return \string The new random token
 2865+ * @param $salt String Optional salt value
 2866+ * @return String The new random token
28652867 */
28662868 public static function generateToken( $salt = '' ) {
28672869 $token = dechex( mt_rand() ) . dechex( mt_rand() );
@@ -2873,8 +2875,8 @@
28742876 * user's own login session, not a form submission from a third-party
28752877 * site.
28762878 *
2877 - * @param $val \string Input value to compare
2878 - * @param $salt \string Optional function-specific data for hashing
 2879+ * @param $val String Input value to compare
 2880+ * @param $salt String Optional function-specific data for hashing
28792881 * @return Boolean: Whether the token matches
28802882 */
28812883 function matchEditToken( $val, $salt = '' ) {
@@ -2889,8 +2891,8 @@
28902892 * Check given value against the token value stored in the session,
28912893 * ignoring the suffix.
28922894 *
2893 - * @param $val \string Input value to compare
2894 - * @param $salt \string Optional function-specific data for hashing
 2895+ * @param $val String Input value to compare
 2896+ * @param $salt String Optional function-specific data for hashing
28952897 * @return Boolean: Whether the token matches
28962898 */
28972899 function matchEditTokenNoSuffix( $val, $salt = '' ) {
@@ -2929,11 +2931,11 @@
29302932 * Send an e-mail to this user's account. Does not check for
29312933 * confirmed status or validity.
29322934 *
2933 - * @param $subject \string Message subject
2934 - * @param $body \string Message body
2935 - * @param $from \string Optional From address; if unspecified, default $wgPasswordSender will be used
2936 - * @param $replyto \string Reply-To address
2937 - * @return Status object
 2935+ * @param $subject String Message subject
 2936+ * @param $body String Message body
 2937+ * @param $from String Optional From address; if unspecified, default $wgPasswordSender will be used
 2938+ * @param $replyto String Reply-To address
 2939+ * @return Status
29382940 */
29392941 function sendMail( $subject, $body, $from = null, $replyto = null ) {
29402942 if( is_null( $from ) ) {
@@ -2955,7 +2957,7 @@
29562958 * this change to the database.
29572959 *
29582960 * @param[out] &$expiration \mixed Accepts the expiration time
2959 - * @return \string New token
 2961+ * @return String New token
29602962 * @private
29612963 */
29622964 function confirmationToken( &$expiration ) {
@@ -2972,8 +2974,8 @@
29732975
29742976 /**
29752977 * Return a URL the user can use to confirm their email address.
2976 - * @param $token \string Accepts the email confirmation token
2977 - * @return \string New token URL
 2978+ * @param $token String Accepts the email confirmation token
 2979+ * @return String New token URL
29782980 * @private
29792981 */
29802982 function confirmationTokenUrl( $token ) {
@@ -2982,8 +2984,8 @@
29832985
29842986 /**
29852987 * Return a URL the user can use to invalidate their email address.
2986 - * @param $token \string Accepts the email confirmation token
2987 - * @return \string New token URL
 2988+ * @param $token String Accepts the email confirmation token
 2989+ * @return String New token URL
29882990 * @private
29892991 */
29902992 function invalidationTokenUrl( $token ) {
@@ -3000,9 +3002,9 @@
30013003 * also sometimes can get corrupted in some browsers/mailers
30023004 * (bug 6957 with Gmail and Internet Explorer).
30033005 *
3004 - * @param $page \string Special page
3005 - * @param $token \string Token
3006 - * @return \string Formatted URL
 3006+ * @param $page String Special page
 3007+ * @param $token String Token
 3008+ * @return String Formatted URL
30073009 */
30083010 protected function getTokenUrl( $page, $token ) {
30093011 global $wgArticlePath;
@@ -3041,7 +3043,7 @@
30423044
30433045 /**
30443046 * Set the e-mail authentication timestamp.
3045 - * @param $timestamp \string TS_MW timestamp
 3047+ * @param $timestamp String TS_MW timestamp
30463048 */
30473049 function setEmailAuthenticationTimestamp( $timestamp ) {
30483050 $this->load();
@@ -3052,7 +3054,7 @@
30533055 /**
30543056 * Is this user allowed to send e-mails within limits of current
30553057 * site configuration?
3056 - * @return Boolean: True if allowed
 3058+ * @return Bool
30573059 */
30583060 function canSendEmail() {
30593061 global $wgEnableEmail, $wgEnableUserEmail;
@@ -3067,7 +3069,7 @@
30683070 /**
30693071 * Is this user allowed to receive e-mails within limits of current
30703072 * site configuration?
3071 - * @return Boolean: True if allowed
 3073+ * @return Bool
30723074 */
30733075 function canReceiveEmail() {
30743076 return $this->isEmailConfirmed() && !$this->getOption( 'disablemail' );
@@ -3081,7 +3083,7 @@
30823084 * confirmed their address by returning a code or using a password
30833085 * sent to the address from the wiki.
30843086 *
3085 - * @return Boolean: True if confirmed
 3087+ * @return Bool
30863088 */
30873089 function isEmailConfirmed() {
30883090 global $wgEmailAuthentication;
@@ -3102,7 +3104,7 @@
31033105
31043106 /**
31053107 * Check whether there is an outstanding request for e-mail confirmation.
3106 - * @return Boolean: True if pending
 3108+ * @return Bool
31073109 */
31083110 function isEmailConfirmationPending() {
31093111 global $wgEmailAuthentication;
@@ -3115,8 +3117,8 @@
31163118 /**
31173119 * Get the timestamp of account creation.
31183120 *
3119 - * @return \types{\string,\bool} string Timestamp of account creation, or false for
3120 - * non-existent/anonymous user accounts.
 3121+ * @return String|Bool Timestamp of account creation, or false for
 3122+ * non-existent/anonymous user accounts.
31213123 */
31223124 public function getRegistration() {
31233125 return $this->getId() > 0
@@ -3127,8 +3129,8 @@
31283130 /**
31293131 * Get the timestamp of the first edit
31303132 *
3131 - * @return \types{\string,\bool} string Timestamp of first edit, or false for
3132 - * non-existent/anonymous user accounts.
 3133+ * @return String|Bool Timestamp of first edit, or false for
 3134+ * non-existent/anonymous user accounts.
31333135 */
31343136 public function getFirstEditTimestamp() {
31353137 if( $this->getId() == 0 ) {
@@ -3149,8 +3151,8 @@
31503152 /**
31513153 * Get the permissions associated with a given list of groups
31523154 *
3153 - * @param $groups \type{\arrayof{\string}} List of internal group names
3154 - * @return \type{\arrayof{\string}} List of permission key names for given groups combined
 3155+ * @param $groups Array of Strings List of internal group names
 3156+ * @return Array of Strings List of permission key names for given groups combined
31553157 */
31563158 static function getGroupPermissions( $groups ) {
31573159 global $wgGroupPermissions, $wgRevokePermissions;
@@ -3176,8 +3178,8 @@
31773179 /**
31783180 * Get all the groups who have a given permission
31793181 *
3180 - * @param $role \string Role to check
3181 - * @return \type{\arrayof{\string}} List of internal group names with the given permission
 3182+ * @param $role String Role to check
 3183+ * @return Array of Strings List of internal group names with the given permission
31823184 */
31833185 static function getGroupsWithPermission( $role ) {
31843186 global $wgGroupPermissions;
@@ -3193,8 +3195,8 @@
31943196 /**
31953197 * Get the localized descriptive name for a group, if it exists
31963198 *
3197 - * @param $group \string Internal group name
3198 - * @return \string Localized descriptive group name
 3199+ * @param $group String Internal group name
 3200+ * @return String Localized descriptive group name
31993201 */
32003202 static function getGroupName( $group ) {
32013203 $key = "group-$group";
@@ -3207,8 +3209,8 @@
32083210 /**
32093211 * Get the localized descriptive name for a member of a group, if it exists
32103212 *
3211 - * @param $group \string Internal group name
3212 - * @return \string Localized name for group member
 3213+ * @param $group String Internal group name
 3214+ * @return String Localized name for group member
32133215 */
32143216 static function getGroupMember( $group ) {
32153217 $key = "group-$group-member";
@@ -3251,7 +3253,7 @@
32523254
32533255 /**
32543256 * Get a list of implicit groups
3255 - * @return \type{\arrayof{\string}} Array of internal group names
 3257+ * @return Array of Strings Array of internal group names
32563258 */
32573259 public static function getImplicitGroups() {
32583260 global $wgImplicitGroups;
@@ -3263,8 +3265,8 @@
32643266 /**
32653267 * Get the title of a page describing a particular group
32663268 *
3267 - * @param $group \string Internal group name
3268 - * @return \types{\type{Title},\bool} Title of the page if it exists, false otherwise
 3269+ * @param $group String Internal group name
 3270+ * @return Title|Bool Title of the page if it exists, false otherwise
32693271 */
32703272 static function getGroupPage( $group ) {
32713273 $page = wfMsgForContent( 'grouppage-' . $group );
@@ -3280,9 +3282,9 @@
32813283 * Create a link to the group in HTML, if available;
32823284 * else return the group name.
32833285 *
3284 - * @param $group \string Internal name of the group
3285 - * @param $text \string The text of the link
3286 - * @return \string HTML link to the group
 3286+ * @param $group String Internal name of the group
 3287+ * @param $text String The text of the link
 3288+ * @return String HTML link to the group
32873289 */
32883290 static function makeGroupLinkHTML( $group, $text = '' ) {
32893291 if( $text == '' ) {
@@ -3302,9 +3304,9 @@
33033305 * Create a link to the group in Wikitext, if available;
33043306 * else return the group name.
33053307 *
3306 - * @param $group \string Internal name of the group
3307 - * @param $text \string The text of the link
3308 - * @return \string Wikilink to the group
 3308+ * @param $group String Internal name of the group
 3309+ * @param $text String The text of the link
 3310+ * @return String Wikilink to the group
33093311 */
33103312 static function makeGroupLinkWiki( $group, $text = '' ) {
33113313 if( $text == '' ) {
@@ -3324,9 +3326,9 @@
33253327 *
33263328 * @param $group String: the group to check for whether it can add/remove
33273329 * @return Array array( 'add' => array( addablegroups ),
3328 - * 'remove' => array( removablegroups ),
3329 - * 'add-self' => array( addablegroups to self),
3330 - * 'remove-self' => array( removable groups from self) )
 3330+ * 'remove' => array( removablegroups ),
 3331+ * 'add-self' => array( addablegroups to self),
 3332+ * 'remove-self' => array( removable groups from self) )
33313333 */
33323334 static function changeableByGroup( $group ) {
33333335 global $wgAddGroups, $wgRemoveGroups, $wgGroupsAddToSelf, $wgGroupsRemoveFromSelf;
@@ -3475,8 +3477,8 @@
34763478 /**
34773479 * Get the description of a given right
34783480 *
3479 - * @param $right \string Right to query
3480 - * @return \string Localized description of the right
 3481+ * @param $right String Right to query
 3482+ * @return String Localized description of the right
34813483 */
34823484 static function getRightDescription( $right ) {
34833485 $key = "right-$right";
@@ -3489,9 +3491,9 @@
34903492 /**
34913493 * Make an old-style password hash
34923494 *
3493 - * @param $password \string Plain-text password
3494 - * @param $userId \string User ID
3495 - * @return \string Password hash
 3495+ * @param $password String Plain-text password
 3496+ * @param $userId String User ID
 3497+ * @return String Password hash
34963498 */
34973499 static function oldCrypt( $password, $userId ) {
34983500 global $wgPasswordSalt;
@@ -3505,10 +3507,10 @@
35063508 /**
35073509 * Make a new-style password hash
35083510 *
3509 - * @param $password \string Plain-text password
3510 - * @param $salt \string Optional salt, may be random or the user ID.
 3511+ * @param $password String Plain-text password
 3512+ * @param $salt String Optional salt, may be random or the user ID.
35113513 * If unspecified or false, will generate one automatically
3512 - * @return \string Password hash
 3514+ * @return String Password hash
35133515 */
35143516 static function crypt( $password, $salt = false ) {
35153517 global $wgPasswordSalt;
@@ -3532,9 +3534,9 @@
35333535 * Compare a password hash with a plain-text password. Requires the user
35343536 * ID if there's a chance that the hash is an old-style hash.
35353537 *
3536 - * @param $hash \string Password hash
3537 - * @param $password \string Plain-text password to compare
3538 - * @param $userId \string User ID for old-style password salt
 3538+ * @param $hash String Password hash
 3539+ * @param $password String Plain-text password to compare
 3540+ * @param $userId String User ID for old-style password salt
35393541 * @return Boolean:
35403542 */
35413543 static function comparePasswords( $hash, $password, $userId = false ) {
@@ -3706,6 +3708,8 @@
37073709 * actually just returns array() unconditionally at the moment. May as
37083710 * well keep it around for when the browser bugs get fixed, though.
37093711 *
 3712+ * FIXME : This does not belong here; put it in Html or Linker or somewhere
 3713+ *
37103714 * @return array Array of HTML attributes suitable for feeding to
37113715 * Html::element(), directly or indirectly. (Don't feed to Xml::*()!
37123716 * That will potentially output invalid XHTML 1.0 Transitional, and will
Index: trunk/phase3/includes/Article.php
@@ -58,7 +58,7 @@
5959
6060 /**
6161 * Constructor from an page id
62 - * @param $id The article ID to load
 62+ * @param $id Int article ID to load
6363 */
6464 public static function newFromID( $id ) {
6565 $t = Title::newFromID( $id );
@@ -1175,7 +1175,7 @@
11761176 * merging of several policies using array_merge().
11771177 * @param $policy Mixed, returns empty array on null/false/'', transparent
11781178 * to already-converted arrays, converts String.
1179 - * @return associative Array: 'index' => <indexpolicy>, 'follow' => <followpolicy>
 1179+ * @return Array: 'index' => <indexpolicy>, 'follow' => <followpolicy>
11801180 */
11811181 public static function formatRobotPolicy( $policy ) {
11821182 if ( is_array( $policy ) ) {
@@ -1525,7 +1525,7 @@
15261526 /**
15271527 * View redirect
15281528 *
1529 - * @param $target Title object or Array of destination(s) to redirect
 1529+ * @param $target Title|Array of destination(s) to redirect
15301530 * @param $appendSubtitle Boolean [optional]
15311531 * @param $forceKnown Boolean: should the image be shown as a bluelink regardless of existence?
15321532 * @return string containing HMTL with redirect link
@@ -1813,7 +1813,7 @@
18141814 * Add row to the redirect table if this is a redirect, remove otherwise.
18151815 *
18161816 * @param $dbw Database
1817 - * @param $redirectTitle a title object pointing to the redirect target,
 1817+ * @param $redirectTitle Title object pointing to the redirect target,
18181818 * or NULL if this is not a redirect
18191819 * @param $lastRevIsRedirect If given, will optimize adding and
18201820 * removing rows in redirect table.
@@ -2050,7 +2050,7 @@
20512051 * auto-detection due to MediaWiki's performance-optimised locking strategy.
20522052 *
20532053 * @param $baseRevId the revision ID this edit was based off, if any
2054 - * @param $user Optional user object, $wgUser will be used if not passed
 2054+ * @param $user User (optional), $wgUser will be used if not passed
20552055 *
20562056 * @return Status object. Possible errors:
20572057 * edit-hook-aborted: The ArticleSave hook aborted the edit but didn't set the fatal flag of $status
@@ -3615,7 +3615,7 @@
36163616 * @param $text String: New text of the article
36173617 * @param $summary String: Edit summary
36183618 * @param $minoredit Boolean: Minor edit
3619 - * @param $timestamp_of_pagechange Timestamp associated with the page change
 3619+ * @param $timestamp_of_pagechange String timestamp associated with the page change
36203620 * @param $newid Integer: rev_id value of the new revision
36213621 * @param $changed Boolean: Whether or not the content actually changed
36223622 * @param $user User object: User doing the edit
@@ -4004,7 +4004,7 @@
40054005 wfProfileOut( __METHOD__ );
40064006 }
40074007
4008 - /**#@+
 4008+ /**
40094009 * The onArticle*() functions are supposed to be a kind of hooks
40104010 * which should be called whenever any of the specified actions
40114011 * are done.
@@ -4013,7 +4013,7 @@
40144014 *
40154015 * This is called on page move and undelete, as well as edit
40164016 *
4017 - * @param $title a title object
 4017+ * @param $title Title object
40184018 */
40194019 public static function onArticleCreate( $title ) {
40204020 # Update existence markers on article/talk tabs...
@@ -4270,7 +4270,7 @@
42714271 * Return an applicable autosummary if one exists for the given edit.
42724272 * @param $oldtext String: the previous text of the page.
42734273 * @param $newtext String: The submitted text of the page.
4274 - * @param $flags Bitmask: a bitmask of flags submitted for the edit.
 4274+ * @param $flags Int bitmask: a bitmask of flags submitted for the edit.
42754275 * @return string An appropriate autosummary, or an empty string.
42764276 */
42774277 public static function getAutosummary( $oldtext, $newtext, $flags ) {

Status & tagging log