r79714 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r79713‎ | r79714 | r79715 >
Date:10:51, 6 January 2011
Author:platonides
Status:ok
Tags:
Comment:
Prepare for r79568. This uses a different hash key for pages without edit links,
which doesn't matter here (deploying pre-r70783), but will avoid parser cache
misses for those on a later deploy of r79520 & Co.
Modified paths:
  • /branches/REL1_17/phase3/includes/parser/ParserOptions.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/parser/ParserOptions.php
——@@ -314,8 +314,12 @@
315315
316316 $confstr .= $wgRenderHashAppend;
317317
318 - if ( !$this->mEditSection && in_array( 'editsection', $forOptions ) )
 318+ if ( !in_array( 'editsection', $forOptions ) ) {
 319+ $confstr .= '!*';
 320+ } elseif ( !$this->mEditSection ) {
319321 $confstr .= '!edit=0';
 322+ }
 323+
320324 if ( $this->mIsPrintable && in_array( 'printable', $forOptions ) )
321325 $confstr .= '!printable=1';
322326

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70783Use only the page relevant pieces in the parser cache key. Eg. two users with...platonides21:53, 9 August 2010
r79520Try to output editsection markers instead of rendered editsection links and d...dantman20:17, 3 January 2011
r79568Partial revert of r79520, follow up to r79558. Unconditionally use the new fo...platonides11:31, 4 January 2011

Status & tagging log