r79685 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79684‎ | r79685 | r79686 >
Date:23:20, 5 January 2011
Author:platonides
Status:ok
Tags:
Comment:
Remove the createaccount error check, failing since r79377.
The * group have createaccount right, so this seems an error.
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/TitlePermissionTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/TitlePermissionTest.php
@@ -338,8 +338,6 @@
339339
340340 $this->assertEquals( array( array( 'badaccess-group0' ), array( 'ns-specialprotected' ) ),
341341 $this->title->getUserPermissionsErrors( 'bogus', $this->user ) );
342 - $this->assertEquals( array( array( 'badaccess-groups', "*, [[$prefix:Administrators|Administrators]]", 2 ) ),
343 - $this->title->getUserPermissionsErrors( 'createaccount', $this->user ) );
344342 $this->assertEquals( array( array( 'badaccess-group0' ) ),
345343 $this->title->getUserPermissionsErrors( 'execute', $this->user ) );
346344

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79377Solve 1 test by changing static variables to non-staticsoxred9322:08, 31 December 2010

Status & tagging log