r79630 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79629‎ | r79630 | r79631 >
Date:22:49, 4 January 2011
Author:reedy
Status:resolved
Tags:
Comment:
More for r79625, add index to improve query efficiency code_comment (cc_repo_id, cc_user_text, cc_timestamp)
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.php (modified) (history)
  • /trunk/extensions/CodeReview/archives/code_comment_author-index.sql (added) (history)
  • /trunk/extensions/CodeReview/codereview.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.php
@@ -213,6 +213,9 @@
214214 "$base/archives/code_signoffs_userid.sql", true ) );
215215 $updater->addExtensionUpdate( array( 'addField', 'code_signoffs', 'cs_timestamp_struck',
216216 "$base/archives/code_signoffs_timestamp_struck.sql", true ) );
 217+
 218+ $updater->addExtensionUpdate( array( 'addIndex', 'code_comments', 'cc_author',
 219+ "$base/archives/code_comment_author-index.sql", true ) );
217220 break;
218221 case 'sqlite':
219222 $updater->addExtensionUpdate( array( 'addTable', 'code_rev', "$base/codereview.sql", true ) );
Index: trunk/extensions/CodeReview/codereview.sql
@@ -194,6 +194,7 @@
195195
196196 CREATE INDEX /*i*/cc_repo_id ON /*_*/code_comment (cc_repo_id,cc_rev_id,cc_sortkey);
197197 CREATE INDEX /*i*/cc_repo_time ON /*_*/code_comment (cc_repo_id,cc_timestamp);
 198+CREATE INDEX /*i*/cc_author ON /*_*/code_comment (cc_repo_id, cc_user_text, cc_timestamp);
198199
199200 --
200201 -- Changes to review metadata for a single code revision.
Index: trunk/extensions/CodeReview/archives/code_comment_author-index.sql
@@ -0,0 +1,2 @@
 2+ALTER TABLE /*$wgDBprefix*/code_comment
 3+ ADD key /*i*/cc_author (cc_repo_id, cc_user_text, cc_timestamp);
Property changes on: trunk/extensions/CodeReview/archives/code_comment_author-index.sql
___________________________________________________________________
Added: svn:eol-style
14 + native

Follow-up revisions

RevisionCommit summaryAuthorDate
r79631Followup r76930, drop s from table name checkreedy22:51, 4 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79625Structural changes to allow filtering by comments...reedy22:35, 4 January 2011

Status & tagging log