r79601 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79600‎ | r79601 | r79602 >
Date:21:17, 4 January 2011
Author:krinkle
Status:deferred
Tags:
Comment:
undoing accidential collision/revert of r79598
Modified paths:
  • /trunk/extensions/Translate/SpecialLanguageStats.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/SpecialLanguageStats.php
@@ -224,7 +224,6 @@
225225 }
226226
227227 protected function makeGroupGroup( $item, $cache, $parent = '' ) {
228 - $out = '';
229228 if ( !is_array( $item ) ) {
230229 return $this->makeGroupRow( $item, $cache, $parent === '' ? false : $parent );
231230 }
@@ -252,7 +251,7 @@
253252 $blacklisted = $this->isBlacklisted( $groupId, $code );
254253
255254 if ( $blacklisted !== null ) {
256 - continue;
 255+ return '';
257256 }
258257
259258 $fuzzy = $translated = $total = 0;
@@ -271,12 +270,12 @@
272271 if ( $total == 0 ) {
273272 $zero = serialize( $total );
274273 error_log( __METHOD__ . ": Group $groupName has zero message ($code): $zero" );
275 - continue;
 274+ return '';
276275 }
277276
278277 // Skip if $suppressComplete and complete
279278 if ( $suppressComplete && !$fuzzy && $translated === $total ) {
280 - continue;
 279+ return '';
281280 }
282281
283282 if ( $translated === $total ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r79603- No longer needed if-check...krinkle21:45, 4 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79598Switch continue; in non loop to return '';...reedy21:09, 4 January 2011

Status & tagging log