r79588 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79587‎ | r79588 | r79589 >
Date:18:26, 4 January 2011
Author:yaron
Status:deferred
Tags:
Comment:
Fix for "remove" button for multiple-instance templates with complex formatting
Modified paths:
  • /trunk/extensions/SemanticForms/libs/SemanticForms.js (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/libs/SemanticForms.js
@@ -688,7 +688,8 @@
689689 }
690690 );
691691
692 - jQuery(this).parent().remove();
 692+ // Remove the encompassing div for this instance.
 693+ jQuery(this).parents(".multipleTemplate").remove();
693694 });
694695
695696 // Enable autocompletion
@@ -765,7 +766,8 @@
766767 });
767768
768769 jQuery(".remover").click( function() {
769 - jQuery(this).parent().remove();
 770+ // Remove the encompassing div for this instance.
 771+ jQuery(this).parents(".multipleTemplate").remove();
770772 });
771773 jQuery(".autocompleteInput").attachAutocomplete();
772774 jQuery(".sfComboBox").combobox();

Status & tagging log