r79552 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79551‎ | r79552 | r79553 >
Date:02:18, 4 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r79545, we don't really care for duplicate userrights
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryAllUsers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryAllUsers.php
@@ -210,7 +210,8 @@
211211 $lastUserData['rights'] = User::getGroupPermissions( User::getImplicitGroups() );
212212 }
213213
214 - $lastUserData['rights'] = array_merge( $lastUserData['rights'], User::getGroupPermissions( array( $row->ug_group2 ) ) );
 214+ $lastUserData['rights'] = array_unique( array_merge( $lastUserData['rights'],
 215+ User::getGroupPermissions( array( $row->ug_group2 ) ) ) );
215216 $result->setIndexedTagName( $lastUserData['rights'], 'r' );
216217 }
217218 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79545* (bug 25767) Add userrights properties to allusers and users query lists...reedy01:39, 4 January 2011

Status & tagging log