r79550 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79549‎ | r79550 | r79551 >
Date:02:08, 4 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Crappy spaces from r79549
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryAllUsers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryAllUsers.php
@@ -77,13 +77,13 @@
7878 $groups = array_merge( $groups, User::getGroupsWithPermission( $r ) );
7979 }
8080
81 - $groups = array_diff( array_unique( $groups ), User::getImplicitGroups() );
 81+ $groups = array_diff( array_unique( $groups ), User::getImplicitGroups() );
8282
83 - if ( is_null( $params['group'] ) ) {
 83+ if ( is_null( $params['group'] ) ) {
8484 $params['group'] = $groups;
85 - } else {
 85+ } else {
8686 $params['group'] = array_unique( array_merge( $params['group'], $groups ) );
87 - }
 87+ }
8888 }
8989
9090 if ( !is_null( $params['group'] ) ) {
@@ -205,14 +205,14 @@
206206 $result->setIndexedTagName( $lastUserData['groups'], 'g' );
207207 }
208208
209 - if ( $fld_rights && !is_null( $row->ug_group2 ) ) {
 209+ if ( $fld_rights && !is_null( $row->ug_group2 ) ) {
210210 if ( !isset( $lastUserData['rights'] ) ) {
211211 $lastUserData['rights'] = User::getGroupPermissions( User::getImplicitGroups() );
212 - }
 212+ }
213213
214 - $lastUserData['rights'] = array_merge( $lastUserData['rights'], User::getGroupPermissions( array( $row->ug_group2 ) ) );
215 - $result->setIndexedTagName( $lastUserData['rights'], 'r' );
216 - }
 214+ $lastUserData['rights'] = array_merge( $lastUserData['rights'], User::getGroupPermissions( array( $row->ug_group2 ) ) );
 215+ $result->setIndexedTagName( $lastUserData['rights'], 'r' );
 216+ }
217217 }
218218
219219 if ( is_array( $lastUserData ) ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79549Rest of * (bug 25767) Add userrights properties to allusers and users query l...reedy02:06, 4 January 2011

Status & tagging log