r79540 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79539‎ | r79540 | r79541 >
Date:00:21, 4 January 2011
Author:yaron
Status:deferred
Tags:
Comment:
Moved SF_ajax_form_preview.js into existing 'ext.semanticforms.main' resource module, instead of having a separate module for it
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_GlobalFunctions.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_Utils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_GlobalFunctions.php
@@ -124,7 +124,10 @@
125125 );
126126 $wgResourceModules += array(
127127 'ext.semanticforms.main' => $sfgResourceTemplate + array(
128 - 'scripts' => 'libs/SemanticForms.js',
 128+ 'scripts' => array(
 129+ 'libs/SemanticForms.js',
 130+ 'libs/SF_ajax_form_preview.js',
 131+ ),
129132 'styles' => array(
130133 'skins/SemanticForms.css',
131134 'skins/SF_jquery_ui_overrides.css',
@@ -141,9 +144,6 @@
142145 'ext.semanticforms.autogrow' => $sfgResourceTemplate + array(
143146 'scripts' => 'libs/SF_autogrow.js',
144147 ),
145 - 'ext.semanticforms.preview' => $sfgResourceTemplate + array(
146 - 'scripts' => 'libs/SF_ajax_form_preview.js',
147 - ),
148148 );
149149 }
150150
Index: trunk/extensions/SemanticForms/includes/SF_Utils.php
@@ -178,7 +178,6 @@
179179 $wgOut->addModules( 'ext.semanticforms.main' );
180180 $wgOut->addModules( 'ext.semanticforms.fancybox' );
181181 $wgOut->addModules( 'ext.semanticforms.autogrow' );
182 - $wgOut->addModules( 'ext.semanticforms.preview' );
183182 $wgOut->addModules( 'ext.smw.tooltips' );
184183 $wgOut->addModules( 'ext.smw.sorttable' );
185184 }

Status & tagging log