r79508 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79507‎ | r79508 | r79509 >
Date:09:05, 3 January 2011
Author:nadeesha
Status:ok
Tags:
Comment:
Remove testOnlyBackButtonAvailability() function as per the code review comment (MediaWiki r78165 )
Modified paths:
  • /trunk/phase3/tests/selenium/installer/MediaWikiButtonsAvailabilityTestCase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/selenium/installer/MediaWikiButtonsAvailabilityTestCase.php
@@ -6,7 +6,7 @@
77 * @file
88 * @ingroup Maintenance
99 * Copyright (C) 2010 Nadeesha Weerasinghe <nadeesha@calcey.com>
10 - * http://www.calcey.com/
 10+ * http://www.calcey.com/
1111 *
1212 * This program is free software; you can redistribute it and/or modify
1313 * it under the terms of the GNU General Public License as published by
@@ -28,7 +28,7 @@
2929 */
3030
3131
32 -require_once ( dirname( __FILE__ ) . '/MediaWikiInstallationCommonFunction.php' );
 32+require_once (dirname(__FILE__).'/'.'MediaWikiInstallationCommonFunction.php');
3333
3434 /*
3535 * Test Case ID : 30 (http://www.mediawiki.org/wiki/New_installer/Test_plan)
@@ -99,21 +99,4 @@
100100 $this->assertTrue( $this->isElementPresent( "submit-back" ));
101101 $this->assertTrue( $this->isElementPresent( "submit-continue" ));
102102 }
103 -
104 -
105 - // Verify only 'Back' button available on 'Complete' page
106 - public function testOnlyBackButtonAvailability() {
107 -
108 - // Verify only 'Back' button available
109 - $databaseName = DB_NAME_PREFIX."_back";
110 - parent::navigateCompletePage( $databaseName );
111 -
112 - // Only 'Back' button available
113 - $this->assertTrue( $this->isElementPresent( "submit-back" ));
114 -
115 - // 'Continue' button is not available
116 - $this->assertElementNotPresent( "submit-continue" );
117 - parent::restartInstallation();
118 - }
119 -}
120 -
 103+}
\ No newline at end of file

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78165* Hide the "back" buttons on the completion pages, they are potentially confu...tstarling03:02, 10 December 2010

Status & tagging log