r79490 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79489‎ | r79490 | r79491 >
Date:14:29, 2 January 2011
Author:ialex
Status:ok
Tags:
Comment:
Replaced call to in_string() by strpos() since the former is not available at the time this function is called from WebStart.php (was breaking the installer)
Modified paths:
  • /trunk/phase3/includes/MWFunction.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/MWFunction.php
@@ -23,7 +23,7 @@
2424 protected static function cleanCallback( $callback ) {
2525
2626 if( is_string( $callback ) ) {
27 - if ( in_string( '::', $callback ) ) {
 27+ if ( strpos( $callback, '::' ) !== false ) {
2828 //PHP 5.1 cannot use call_user_func( 'Class::Method' )
2929 //It can only handle only call_user_func( array( 'Class', 'Method' ) )
3030 $callback = explode( '::', $callback, 2);

Status & tagging log