r79452 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79451‎ | r79452 | r79453 >
Date:22:42, 1 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Per Nikerabbit on IRC, and Bryan on CR (r79451), change back for ===, and intval( $oldid )
Modified paths:
  • /trunk/phase3/includes/api/ApiParse.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiParse.php
@@ -94,7 +94,7 @@
9595 $wgTitle = $titleObj;
9696
9797 // If for some reason the "oldid" is actually the current revision, it may be cached
98 - if ( $titleObj->getLatestRevID() == $oldid ) {
 98+ if ( $titleObj->getLatestRevID() === intval( $oldid ) ) {
9999 $p_result = false;
100100 $pcache = ParserCache::singleton();
101101

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79451Followup r75334. Change to int == string, rather than int === string (not goi...reedy22:35, 1 January 2011

Status & tagging log