r79414 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79413‎ | r79414 | r79415 >
Date:06:49, 1 January 2011
Author:soxred93
Status:ok
Tags:
Comment:
Add parsertest specific help to PHPUnit.php
Modified paths:
  • /trunk/phase3/tests/phpunit/MediaWikiPHPUnitCommand.php (modified) (history)
  • /trunk/phase3/tests/phpunit/includes/parser/NewParserTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/MediaWikiPHPUnitCommand.php
@@ -4,13 +4,10 @@
55
66 static $additionalOptions = array(
77 'regex=' => false,
8 - 'record' => false,
98 'file=' => false,
109 'keep-uploads' => false,
1110 );
1211
13 - //Fixme: These aren't shown on the --help menu
14 -
1512 public function __construct() {
1613 foreach( self::$additionalOptions as $option => $default ) {
1714 $this->longOptions[$option] = $option . 'Handler';
@@ -31,4 +28,19 @@
3229 }
3330 }
3431
 32+ public function showHelp() {
 33+ parent::showHelp();
 34+
 35+ print <<<EOT
 36+
 37+ParserTest-specific options:
 38+
 39+ --regex="<regex>" Only run parser tests that match the given regex
 40+ --file="<filename>" Prints the version and exits.
 41+ --keep-uploads Re-use the same upload directory for each test, don't delete it
 42+
 43+
 44+EOT;
 45+ }
 46+
3547 }
Index: trunk/phase3/tests/phpunit/includes/parser/NewParserTest.php
@@ -24,10 +24,6 @@
2525
2626 //Setup CLI arguments
2727 if ( $this->getCliArg( 'regex=' ) ) {
28 - if ( $this->getCliArg( 'record' ) ) {
29 - echo "Warning: --record cannot be used with --regex, disabling --record\n";
30 - $this->setCliArg( 'record', false );
31 - }
3228 $this->regex = $this->getCliArg( 'regex=' );
3329 } else {
3430 # Matches anything

Status & tagging log