r79409 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79408‎ | r79409 | r79410 >
Date:02:26, 1 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Sorting by cr_id, even when filtering by path gives a non filesorting/temporary query. So always use cr_id (rather than sometimes using cp_rev_id)

Similarily, always use ct_rev_id on code tags
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionTagView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -244,7 +244,7 @@
245245 }
246246
247247 function getDefaultSort() {
248 - return strlen( $this->mView->mPath ) ? 'cp_rev_id' : 'cr_id';
 248+ return 'cr_id';
249249 }
250250
251251 function getQueryInfo() {
Index: trunk/extensions/CodeReview/ui/CodeRevisionTagView.php
@@ -18,7 +18,7 @@
1919 }
2020
2121 function getDefaultSort() {
22 - return strlen( $this->mView->mPath ) ? 'cp_rev_id' : 'ct_rev_id';
 22+ return 'ct_rev_id';
2323 }
2424
2525 function getQueryInfo() {

Status & tagging log