r79397 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79396‎ | r79397 | r79398 >
Date:00:59, 1 January 2011
Author:dantman
Status:ok
Tags:
Comment:
Fix php notice in vector from r79383.
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -82,10 +82,12 @@
8383
8484 if ( $wgVectorUseIconWatch ) {
8585 $mode = $this->skin->mTitle->userIsWatching() ? 'unwatch' : 'watch';
86 - $nav['views'][$mode] = $nav['actions'][$mode];
87 - $nav['views'][$mode]['class'] = rtrim('icon ' . $nav['views'][$mode]['class'], ' ');
88 - $nav['views'][$mode]['primary'] = true;
89 - unset($nav['actions'][$mode]);
 86+ if ( isset($nav['actions'][$mode]) ) {
 87+ $nav['views'][$mode] = $nav['actions'][$mode];
 88+ $nav['views'][$mode]['class'] = rtrim('icon ' . $nav['views'][$mode]['class'], ' ');
 89+ $nav['views'][$mode]['primary'] = true;
 90+ unset($nav['actions'][$mode]);
 91+ }
9092 }
9193
9294 foreach ( $nav as $section => $links ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79383Merging Vector's navigation_urls and SkinTemplate's content_actions code into...dantman23:30, 31 December 2010

Status & tagging log