r79381 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79380‎ | r79381 | r79382 >
Date:23:02, 31 December 2010
Author:reedy
Status:ok
Tags:
Comment:
More for bug 23720.

Remove performance restriction. Change for path =, rather than path LIKE

Needs a maintenance script/similar to back populate these...
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -2,7 +2,11 @@
33
44 // Special:Code/MediaWiki
55 class CodeRevisionListView extends CodeView {
6 - public $mRepo, $mPath, $batchForm;
 6+ /**
 7+ * @var CodeRepository
 8+ */
 9+ public $mRepo;
 10+ public $mPath, $batchForm;
711
812 /**
913 * @param $repo CodeRepository or String
@@ -252,9 +256,7 @@
253257 'fields' => $this->getSelectFields(),
254258 'conds' => array(
255259 'cp_repo_id' => $this->mRepo->getId(),
256 - 'cp_path ' . $this->mDb->buildLike( $this->getSVNPath(), $this->mDb->anyString() ),
257 - // performance
258 - 'cp_rev_id > ' . $this->mRepo->getPathSearchHorizon()
 260+ 'cp_path' => $this->getSVNPath(),
259261 ),
260262 'options' => array( 'GROUP BY' => $defaultSort, 'USE INDEX' => array( 'code_path' => 'cp_repo_id' ) ),
261263 'join_conds' => array(

Sign-offs

UserFlagDate
Hasharinspected20:36, 10 March 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r79384Add repopuldateCodePaths maintenance script for bug 23720 (untested, will be ...reedy23:32, 31 December 2010
r79390More refactoring and fixing for bug 23720reedy00:03, 1 January 2011
r79401Minor extra bit for bug 23720, remove performance restrictionreedy01:12, 1 January 2011
r81038(bug 23720) CodeReview doesn't show ancient revisions for a path...reedy17:27, 26 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79379*(bug 23720) CodeReview doesn't show ancient revisions for a path...reedy22:55, 31 December 2010

Status & tagging log