r79362 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79361‎ | r79362 | r79363 >
Date:18:36, 31 December 2010
Author:gigs
Status:ok
Tags:
Comment:
restored cleanups lost when merging code from the modern rev of DPL
Modified paths:
  • /trunk/extensions/GoogleNewsSitemap/GoogleNewsSitemap_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GoogleNewsSitemap/GoogleNewsSitemap_body.php
@@ -118,7 +118,7 @@
119119 }
120120
121121 $feed->outHeader();
122 - while ( $row = $res->fetchObject( $res ) ) {
 122+ foreach ( $res as $row ) {
123123 $title = Title::makeTitle( $row->page_namespace, $row->page_title );
124124
125125 if ( !$title ) {
@@ -188,7 +188,7 @@
189189 $filterSet = array( 'only', 'exclude' );
190190 # Either involves the same JOIN here...
191191 if ( in_array( $this->params['stable'], $filterSet ) || in_array( $this->params['quality'], $filterSet ) ) {
192 - $joins['flaggedpages'] = Array( 'LEFT JOIN', 'page_id = fp_page_id' );
 192+ $joins['flaggedpages'] = array( 'LEFT JOIN', 'page_id = fp_page_id' );
193193 }
194194 switch( $this->params['stable'] ) {
195195 case 'only':
@@ -220,8 +220,8 @@
221221 $currentTableNumber = 1;
222222 $categorylinks = $dbr->tableName( 'categorylinks' );
223223 for ($i = 0; $i < $this->params['catCount']; $i++) {
224 - $joins["$categorylinks AS c$currentTableNumber"] = Array( 'INNER JOIN',
225 - Array( "page_id = c{$currentTableNumber}.cl_from",
 224+ $joins["$categorylinks AS c$currentTableNumber"] = array( 'INNER JOIN',
 225+ array( "page_id = c{$currentTableNumber}.cl_from",
226226 "c{$currentTableNumber}.cl_to={$dbr->addQuotes($this->categories[$i]->getDBKey())}"
227227 )
228228 );
@@ -342,8 +342,8 @@
343343 $cats = $title->getParentCategories();
344344 $str = '';
345345 # the following code is based (stolen) from r56954 of flagged revs.
346 - $catMap = Array();
347 - $catMask = Array();
 346+ $catMap = array();
 347+ $catMask = array();
348348 $msg = wfMsg( 'googlenewssitemap_categorymap' );
349349 if ( !wfEmptyMsg( 'googlenewssitemap_categorymap', $msg ) ) {
350350 $list = explode( "\n*", "\n$msg" );

Status & tagging log